This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-02-22
Channels
- # aatree (2)
- # beginners (14)
- # boot (190)
- # cider (16)
- # cljs-dev (15)
- # cljsjs (6)
- # cljsrn (7)
- # clojure (101)
- # clojure-austin (26)
- # clojure-berlin (2)
- # clojure-estonia (4)
- # clojure-greece (53)
- # clojure-russia (46)
- # clojurescript (44)
- # core-async (12)
- # cursive (57)
- # data-science (49)
- # datomic (5)
- # emacs (8)
- # hoplon (92)
- # ldnclj (20)
- # lein-figwheel (22)
- # leiningen (4)
- # mount (37)
- # om (103)
- # onyx (26)
- # parinfer (70)
- # proton (6)
- # re-frame (32)
- # reagent (1)
- # yada (24)
@mfikes: do you know why in tools.reader
there is a re-binding of resolve-symbol
here? -> https://github.com/clojure/tools.reader/blob/master/src/test/cljs/cljs/tools/reader_test.cljs#L145
I have a problem in replumb and I don't understand what it is meant to accomplish
it is a (defn ^:dynamic resolve-symbol
that throws, is it meant to be bound explicitly for bootstrapped?
maybe my "connazionale" @bronsa can help me here (I apologize for summoning )
@richiardiandrea: the cljs version of tools.reader
doesn't provide a default resolve-symbol
because it's meaningless (there's no runtime support for namespaces in cljs), so it's left to the users of tools.reader
to bind it
@richiardiandrea: it isn't re-bound in that unit test.
perfect, that's what I suspected
In replumb
I have Mike's macro tests here, and they were all failing now -> https://github.com/ScalaConsultants/replumb/blob/tools-reader-bug/test/cljs/replumb/repl_test.cljs#L405
Maybe (binding [reader/resolve-symbol cljs.analyzer/resolve-symbol] ...
is what we need? I am trying
@richiardiandrea: I think your unit tests reflect the way things worked prior to syntax-quote working. Now that http://dev.clojure.org/jira/browse/TRDR-33 is in the dependency used by ClojureScript, those tests will need to be updated.
@richiardiandrea: For example,
`x
used to incorrectly yield
x
@mfikes thanks I am checking
mmm the problem here looks it is the :dynamic
part not rebound/set ... the espression `x in replumb throws as well now
because I am using tools.reader/read-string
and I need to set tools.reader/resolve-symbol
@bronsa: Just wanted to confirm that custom binding tools.reader/resolve-symbol
solves the problem and the only difference is the bug solved in TRDR-33
:
FAIL in (macros) (:)
Executing (defmacro hello ..) as function should return (inc 13)
expected: (= "(inc 13)" out)
actual: (not (= "(inc 13)" "(cljs.core/inc 13)"))
(foo.core/hello (+ 2 3))
(hello (+ 2 3))