Clojurians
#cljs-dev
<
2016-02-23
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes13:02:41

@dnolen: There are a handful of self-host ticket patches which will collide owing to unit tests being added in the same spot. Just a heads-up. I’ll update patches as needed to make sure they apply cleanly whenever they no longer apply against master. (I can’t think of a good way to avoid the problem a priori.)

dnolen13:02:24

@mfikes: of those patches is there one that I should go ahead and apply i.e. doesn’t really require much review? like the Unicode one?

mfikes13:02:56

@dnolen: The Unicode one is indeed very much cut-n-dry

mfikes13:02:17

@dnolen: These are one-liner cut-n-try self-host tickets (one line to the prod code): http://dev.clojure.org/jira/browse/CLJS-1564 http://dev.clojure.org/jira/browse/CLJS-1584 and I think this one is also pretty cut-n-dry http://dev.clojure.org/jira/browse/CLJS-1521 I don’t think I’d characterize the other self-host tickets as cut-n-dry.

dnolen13:02:18

@mfikes: 1584 needs to be rebased now

mfikes13:02:29

Cool… I can take care of that one.

dnolen13:02:39

1564 still has problems on this machine, I will try on another box later

mfikes13:02:15

Cool. Yeah, that one you had strange reader errors. Maybe that one isn’t cut-n-dry then. :confused:

dnolen13:02:08

1573 & 1521 applied

mfikes14:02:27

@dnolen: 1584 rebased

mfikes14:02:53

@dnolen: Thanks. I think that broke the logjam, making it so that the other patches can be rebased and will have unique places for the code revisions :simple_smile:

mfikes16:02:44

@bronsa: The Clojure implementation of tools.reader delegates to some runtime support in classes in clojure.lang when reading maps and sets in order to check for duplicate keys, but the ClojureScript implementation delegates to standard lib fns (set and hash-set). I think this results in no duplicate key checks for the ClojureScript implementation. Was thinking about logging a JIRA but wanted to run it by you first.

bronsa16:02:18

@mfikes: yes, makes sense

bronsa16:02:18

not sure if we can leverage cljs.core to do those checks?

slipset16:02:29

the check is quite easy

slipset16:02:02

since it’s basically a check to see if (eq (count coll) (count set))

bronsa16:02:29

@slipset: we also want good error messages though

slipset16:02:48

if the count was different

mfikes16:02:55

Wow, I didn’t realize this would trigger it (defn f [a] #{(identity a) (identity a)}) :simple_smile:

wildermuthn20:02:49

Hi all! Just getting started with a very minor issue, but want to make sure I’m following the right conventions. When submitting a patch for a JIRA issue, should the included test always be added with the issue number, instead of included into existing tests?

wildermuthn20:02:39

This particular example deals with get-in, http://dev.clojure.org/jira/browse/CLJS-1420, where get-in already has some tests. Right now I have a patch with deftest test-cljs-1420 appended to the end of the test file, but wanted to confirm that this is the right way.

dnolen20:02:14

@wildermuthn: there’s no real hard convention here - that is approach is fine

dnolen20:02:37

it’s more important to have the test than to write in any particular way

dnolen20:02:33

@mfikes: 1585 will need to be rebased

mfikes20:02:11

Yeah, I presumed that -3 is not part of the game :simple_smile: Will rebase it.

mfikes21:02:07

@dnolen: 1585 rebased

dnolen21:02:36

@mfikes thx!

bronsa21:02:24

@mfikes: what's possibly a little more surprising is that #{(gensym) (gensym)} throws

mfikes21:02:56

Yeah, or anything impure :simple_smile:

mfikes21:02:01

I like #((rand) (rand)) (take your chances), or (let [a (atom 1)] #{(swap! a inc) (swap! a inc)}). Fun!

dnolen21:02:02

@mfikes: applied

mfikes21:02:23

@dnolen: Woot! Now at zero bootstrapped bugs, I believe :simple_smile:

dnolen21:02:09

@mfikes: cool I will probably cut a release on Friday since the :parallel-build bug is a pretty bad one

mfikes21:02:19

Awesome :simple_smile:

mfikes21:02:36

That gives us time to bang on it

dnolen21:02:29

@mfikes: you’re now just behind Rich Hickey in the largest number of changes committed to the ClojureScript code base :wink:

mfikes21:02:47

I feel cozy between Rich and Stu :simple_smile:

mfikes21:02:23

Of course, Rich has more lines committed and more everything else :stuck_out_tongue:

richiardiandrea21:02:06

it would be great if you guys want to add CLJS-1515 :smile:

dnolen22:02:48

@wildermuthn: patch applied

wildermuthn22:02:33

Thanks! My small Clojurescript team is going to be taking time each week to attack low-hanging fruit, so hopefully it won’t be the last minor issue we get working.

dnolen22:02:50

@wildermuthn: much appreciated