Fork me on GitHub
#cljdoc
<
2022-04-20
>
lread23:04:32

Pretty quiet on the search feedback here! I’ll assume folks are digging it!

lread23:04:13

@corasaurus-hex I think I’ll make a tweak to searchset tests 🧵

lread23:04:40

I made a change to the sanitizer and it broke the searchset tests.

Cora (she/her)23:04:50

ahhhh ok, for sure

lread23:04:19

It’s hard for me to easily tell what is different. So I’m thinking… I’ll save the expected result maps sorted so I can use convential diff tools to compare.

lread23:04:55

Cool, thanks, I shall make it so!

lread23:04:13

(thanks for you little comment block to regen the results BTW, very handy).

Cora (she/her)23:04:09

I try to do that when data/code is hard to generate

Cora (she/her)23:04:38

and you definitely don't need to ask permission to make changes especially to improve things

Cora (she/her)23:04:55

those tests are pretty shitty tbh

lread23:04:03

Thanks, just wanted to run it by you for potential issues.

lread23:04:26

Hey, they are better than nothin’! I appreciate them!

Cora (she/her)23:04:31

oh for sure! the thing was that I didn't know the data structures well enough to generate input or anticipate output for a lot of these functions and so the tests came last

Cora (she/her)23:04:38

and it was just all repl iteration

Cora (she/her)23:04:01

there's actually a bunch of data we're sending back that I'm not using

lread00:04:58

ah, good to know, we can tackle that in round n!

lread19:04:35

tx! merged!

💜 1