Clojurians Log v2
Clojure programming
Channels
Apps
cljdoc
lread 2022-04-20T23:41:32.263009Z
Pretty quiet on the search feedback here! I’ll assume folks are digging it!
lread 2022-04-20T23:42:13.474819Z
@corasaurus-hex I think I’ll make a tweak to searchset tests 🧵
lread 2022-04-21T18:37:00.470089Z
@corasaurus-hex, I got the https://github.com/cljdoc/cljdoc/pull/596! Care to have a quick glance?
lread 2022-04-21T19:16:35.877169Z
tx! merged!
💜 1
lread 2022-04-20T23:42:40.749179Z
I made a change to the sanitizer and it broke the searchset tests.
Cora (she/her) 2022-04-20T23:42:50.380269Z
ahhhh ok, for sure
lread 2022-04-20T23:43:19.502869Z
It’s hard for me to easily tell what is different. So I’m thinking… I’ll save the expected result maps sorted so I can use convential diff tools to compare.
Cora (she/her) 2022-04-20T23:43:35.580209Z
oh, good idea
lread 2022-04-20T23:43:55.694569Z
Cool, thanks, I shall make it so!
lread 2022-04-20T23:44:13.914599Z
(thanks for you little comment block to regen the results BTW, very handy).
Cora (she/her) 2022-04-20T23:45:09.846629Z
I try to do that when data/code is hard to generate
Cora (she/her) 2022-04-20T23:45:38.882829Z
and you definitely don't need to ask permission to make changes especially to improve things
Cora (she/her) 2022-04-20T23:45:55.882489Z
those tests are pretty shitty tbh
lread 2022-04-20T23:46:03.217599Z
Thanks, just wanted to run it by you for potential issues.
lread 2022-04-20T23:46:26.848589Z
Hey, they are better than nothin’! I appreciate them!
Cora (she/her) 2022-04-20T23:48:31.383939Z
oh for sure! the thing was that I didn't know the data structures well enough to generate input or anticipate output for a lot of these functions and so the tests came last
Cora (she/her) 2022-04-20T23:48:38.995619Z
and it was just all repl iteration
Cora (she/her) 2022-04-20T23:49:01.069349Z
there's actually a bunch of data we're sending back that I'm not using
lread 2022-04-21T00:25:58.739739Z
ah, good to know, we can tackle that in round n!