Clojurians Log v2
Clojure programming
Channels
Apps
clj-commons
jumar 2022-04-20T19:16:46.794679Z
Posting here since I'm not sure anybody is looking at the issues in clj-commons/friend. I made a new issue about redirects: https://github.com/clj-commons/friend/issues/4 Is this something that I can expect to be fixed? Perhaps I should try to make the patch?
seancorfield 2022-04-20T19:25:50.703299Z
We use relative URLs all the time in redirects -- I didn't even know it was supposed to be invalid! I'd say a PR to revert just the absolute URL resolution portion of that commit would be worthwhile and should be non-controversial.
jumar 2022-04-20T19:31:11.557779Z
yeah, the problem with simple revert is that a lot of that code has changed so it's probably not possible O:-)
seancorfield 2022-04-20T19:44:41.636679Z
I use "revert" in a very loose fashion there 🙂 I have never looked at Friend's code (and have never used it).
slipset 2022-04-20T21:32:16.694029Z
PR would be welcome.