Fork me on GitHub
#clj-commons
<
2022-04-20
>
jumar19:04:46

Posting here since I'm not sure anybody is looking at the issues in clj-commons/friend. I made a new issue about redirects: https://github.com/clj-commons/friend/issues/4 Is this something that I can expect to be fixed? Perhaps I should try to make the patch?

seancorfield19:04:50

We use relative URLs all the time in redirects -- I didn't even know it was supposed to be invalid! I'd say a PR to revert just the absolute URL resolution portion of that commit would be worthwhile and should be non-controversial.

jumar19:04:11

yeah, the problem with simple revert is that a lot of that code has changed so it's probably not possible O:-)

seancorfield19:04:41

I use "revert" in a very loose fashion there 🙂 I have never looked at Friend's code (and have never used it).

slipset21:04:16

PR would be welcome.