This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-04-05
Channels
- # announcements (15)
- # aws (7)
- # babashka (105)
- # beginners (35)
- # biff (5)
- # calva (48)
- # cider (5)
- # clj-kondo (25)
- # cljdoc (14)
- # clojure (84)
- # clojure-czech (2)
- # clojure-dev (6)
- # clojure-europe (58)
- # clojure-nl (6)
- # clojure-norway (19)
- # clojure-portugal (2)
- # clojure-uk (5)
- # clojurescript (23)
- # cloverage (5)
- # code-reviews (5)
- # conjure (28)
- # data-science (1)
- # datomic (53)
- # events (6)
- # exercism (7)
- # fulcro (16)
- # graalvm-mobile (2)
- # honeysql (29)
- # improve-getting-started (2)
- # kaocha (32)
- # lambdaisland (2)
- # lsp (29)
- # malli (3)
- # overtone (1)
- # pedestal (8)
- # polylith (3)
- # portal (6)
- # quil (2)
- # rdf (15)
- # releases (2)
- # rewrite-clj (14)
- # sci (9)
- # shadow-cljs (7)
- # specter (5)
- # sql (5)
- # xtdb (38)
What determines the version shown in README badges? I cut a 1.0.0-rc1 for primitive-math, verified it, and cut a 1.0.0 release a few minutes later. The badge link goes to the 1.0.0 documentation, but the badge itself still shows 1.0.0-rc1. You can see it at https://github.com/clj-commons/primitive-math
Hey kingmob 👋🙂
when calling https://cljdoc.org/badge/group-id/artifact-id, we look up the most recent cljdoc build and return the Badgen link for this version. I just learned that when your group-id and artifact-id are identical it also works when you just call https://cljdoc.org/badge/that-id. You cannot provide your own version-id when calling this endpoint though. There has been some discussion here already it seems: https://github.com/cljdoc/cljdoc/issues/348
Maybe the build just did not complete yet when you tried it? At the moment the version looks fine, right? I see 1.0.0
as expected.
But when the 1.0.0-rc1
link already resolved to the 1.0.0
documentation version the build must have been completed :thinking_face:
On both routes (badge & documentation) the latest release version is resolved the same way internally. I don't really have an explanation how this can get out of sync.
I think GitHub may cache the badge image for a while? Or maybe the caching is somewhere else but based on @ULHUNM4NM said, sounds like its likely a caching issue?
Ya GitHub https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/about-anonymized-urls#an-image-that-changed-recently-is-not-updating. And there is always your browser cache too... But we should double check our cache control headers for badges.
Good point 👍 we are currently setting a custom max-age
of 30 min for badges, which would explain it.
Thanks for reporting that @U10EC98F5 👍 I guess there is still room for improvement concerning the badge caching from our side, I just opened an issue for that: https://github.com/cljdoc/cljdoc/issues/573
OOhhhhh, I’ve been gone for a little while it seems. Lovely to see so many things happening here! Great to have you back @corasaurus-hex and thanks @lee for being so present 🙂 If there’s anything you need from me please put it in this thread and I’ll try to get back to it this week 💚
In case you’re wondering: everything is going well in my life. I’m still in Cape Town for a little bit and it’s just been “full with good times”… sometimes in a way that’s a challenge to balance with work 😅 so when I’m at the computer I mostly try to keep up with that. Going back to Berlin in a week or so, which might be a good change of pace in that regard but we’ll see. Hope everyone is well and you’re enjoying the spring if it has already reached your respective location 😄
that is the best sort of reason for being absent and I happily endorse it!! take your time and enjoy a little extra just for us 💜
Welcome back 🥳