There’s a few unreviewed PRs currently open. I’ll try to give them a review this week but if anyone else feels like helping out by reviewing some code, please check ’em out 🙂 https://github.com/cljdoc/cljdoc/pulls

I'm a bit distracted right now, but @deleted-user if you enjoy such activities and have time/interest, please do feel free to dive in!

Woot! We have another cljdoc dev team reviewer! 🎉

Yeah, I think docs should be updated, probably here: https://github.com/cljdoc/cljdoc/blob/master/doc/userguide/for-library-authors.adoc

There's also a validator of sorts... but having it check url could be a separate piece of work. https://github.com/cljdoc/cljdoc/blob/master/script/verify-cljdoc-edn And we were thinking of making a new babashka version of this thing anyway... so probably best to think about it separately.

hmmm.... yeah.

Yeah, I was kind of working on something there but got distracted!

Are we visually showing an external url differently in our UI?

Do we need/want to?

The spec, if I remember correctly, might not be applied at analysis time... vague recentish memories... but something might be a bit non-obvious about when that user config cljdoc.edn spec is applied.

Ah so when being fetched from the db, not when analyzed to be put in the db?

Yeah... I think I was noticing that and that's why I was working on some validation for cljdoc.edn.

Oh I could be out to lunch, entirely possible. 🙂

Ha! There's only a few marbles rattling around in there!

Better make a note to myself on this one!

grasp is very cool but more for searching for code, no?

I was actually playing with malli for validating cljdoc.edn (outside of thinking about a bb script) but then switched to rewrite-clj because it seemed more straightforward to get good errors with line/col.

Hmm... clj-kondo already validates bb.edn and deps.edn I wonder if it could validate cljdoc.edn? I don't think its hooks support edn files.

We should add a hook for it

(are we just trolling borkdude with keywords to see how many times we can get his attention?)

so you can do your own linting

Can clj-kondo hooks currently hook into .edn files?

no: we should add a hook for it

Gotcha. Maybe. Was thinking a custom hook hosted by cljdoc would make sense. Or would a hook for this in clj-kondo itself be of interest?

What I mean is: clj-kondo should support linting .edn files using a hook

so you can implement your own rules on it

Now I really get what you are getting at. Yep, that is what I was thinking as well.

Perhaps cljdoc can test drive this :)

Shall I raise an issue over at clj-kondo?

sure

Would be nice to just have it in clj-kondo too though because that would mean you get automagic validation when you use clj-kondo

(vs. something that is external and people have to add manually)

for now I'd rather support the hook rather than having it built-in. you can get the hook via a dependency

it's more flexible growing this "outside" first

and it covers more use cases for more apps with their own .edn rules

Yeah @martinklepsch, clj-kondo supports hook export/import. Clj-kondo user will still have to opt in, but we can add instructions.

I suppose tooling that sits atop clj-kondo like clojure-lsp could choose to auto-opt-in... or make opt-in obvious/easy.

But that's a whole other topic.

This concludes our "how to summon borkdude" experiment. 🙂

just include the cljdoc-awesome-dev-tools deps in your REPL alias or so

and include your REPL alias in LSP

anyway, issue(s) welcome!

First stab at issue: https://github.com/clj-kondo/clj-kondo/issues/1392

@lee yes. seems good. the code for linting bb.edn/deps.edn is at the bottom in impl/analyzer.clj

I vaguely remember dabbling about in there.

if you want to you whip up some prototype. I can imagine a :hooks {:file {...}} kind of thing where you have some filter on the filename or path and the hook receive the entire rewrite-edn node of the file + some other properties as a map

and you can do the same kind of things as in any other hook

and possibly transform the node as well by returning it, or just leave it by not returning it or returning the same one

possibly the file hook also wants to see the entire source string

so we can just add more stuff to the input map

Yeah sounds good. What about the hook checking if files referenced in edn exist? Would that be possible or would that be a security concern?

don't know :)

perhaps people should explicitly allow certain functions in hooks?

That's interesting yeah, by installing this hook, you are allowing it to ___.

what if you have a jar file though? this complicates the situation

I mean you can look around in the jar file etc

we can also just ignore all that for now

and see how far we get

perhaps people can add ;; cljdoc yes for realz in their file to enable the linting

or so

But really, I'm supposed to be working on my GraalVM failure on Windows for rewrite-clj. I swear, I used to be a focused person!

in the case of .clj-kondo/config.edn the filename would be config.edn but .clj-kondo would make it pretty clear

ok, I won't distract you any further... hey wait, you started!

Yeah, exactly, I'm the problem! Or maybe it is not a problem.

we could make a safe function that lists the files from the current dir or so

etc.

you're a good problem to have my friend

Ah, very kind of you to say!

although you are with early retirement or so, it seems we keep you busy, haha

It is a win-win!