Fork me on GitHub
#cljdoc
<
2018-10-19
>
Daw-Ran Liou01:10:02

Hi @martinklepsch I made a PR for adding the 404 page (https://github.com/cljdoc/cljdoc/pull/166), would you give me some feedbacks? I’m still learning frontend stuffs (and Tachyons CSS framework) so I was mostly trying to replicate the home page. However, I couldn’t make the page look better on the mobile devices.

martinklepsch07:10:13

@U7PQH43PS hey! 🙂 It looks great, is there anything specific that you think should be improved about the mobile pages? they look reasonable to me... 🙂

Daw-Ran Liou14:10:09

I just felt like there’s something more to make it look nicer. :P

Daw-Ran Liou14:10:30

Thanks for the comments. I’ll address those in the same PR.

martinklepsch14:10:18

Awesome, feel free to ping me if you have any questions 🙂

Daw-Ran Liou22:10:40

Hey @martinklepsch, I updated the PR. Would you mind taking a look again? Also, would adding test for the 404 response be a good idea? I haven't spent time understanding the tests in cljdoc (also clojure in general) but I can start getting to it.