If you're not using that library you could just gitignore it. I do check in configs for libs that I am using, so everyone has the same clj-kondo config, but whatever works best for you. does cljfmt support an ignore setting?

I think probably, but I’m currently working out how lsp and cljfmt work together, so I think I’ll just exclude it in deps.edn. That should prevent the clj-kondo config from being imported, correct?

yes, I think so

as long as it doesn't get into your classpath

Yup. At least clj -Stree doesn’t show it 🙂

Thanks!

I agree the cljfmt ignore would be more surgical. And maybe I’ll just submit a patch upstream and see if they take it. Thanks!

good luck! :)

(defprotocol Body
  (to-body [x]))

(extend-protocol Body
  (class (byte-array 0))
  (to-body [this] (RequestBody/fromBytes this)))

kondo complains that Function arguments should be wrapped in vector.

Which library is this. It is not valid code. See a recent discussion in #CF595DNF7

This code only works by accident

(https://clojurians.slack.com/archives/CF595DNF7/p1676305329884289)

Thanks, it’s internal code unfortunately

why is that unfortunately? then you can change it right?

Oh yes! I meant that I could not show you in situ

Something like this should work:

(defprotocol Body
  (to-body [x]))

(extend (class (byte-array 0))
  Body {:to-body (fn [this] (RequestBody/fromBytes this))})

Thank you, I’ll give that a try!

In the above thread @U060FKQPN explains why there are issues with code like, but it is not clear if those issues are a bug in the extend-protocol definition, or if that is invalid code

Given that it only works accidentally for one case, but not when you provide some combination of other stuff (in which clj emits an invalid type hint like ^(class (byte-array 0))) in the expansion) I'd not use it at all at this point, but it would be good if the core team (@U064X3EF3 ?) could shed some light on this if it's supported or a bug.

https://clojure.atlassian.net/browse/CLJ-1381 appears to be this issue, but not a lot of commentary

I personally wouldn't mind if the solution was (extend-protocol Foobar bytes ...)

but given that there is extend perhaps we don't need it

In Clojure 1.12 you can write byte*

don't get too attached to the foo* :)

you can also use the string form in this code I believe

"[B"

guess not, I thought there was some other workaround but maybe the code up top is what I'm thinking of

but wherever we end up on the class array stuff, that would help regardless