Check all the keys in the hook arg, it nay already be in there

@borkdude ugh, I printed the whole thing before and didn’t see :namespace but of course it’s here as :ns. I’m making a strong effort to not waste your time here, I promise!!

@borkdude but while I have you, I was thinking that one nice function in a hook would be something like fmap ; the pattern of (api/token-node (f (:value node))) , (api/list-node (f (:children node))) etc would be instead (api/fmap f node) in both cases

powered by a protocol offering fmap* or something so you could correctly dispatch on the non-function arg

@borkdude it won’t quite work due to caching, I think. here is what I tried:

(defn define-coordinates [{:keys [node ns]}]
  (let [[_ _ system] (:children node)
        analysis (api/ns-analysis ns)
        existing (into (set (keys (:clj analysis)))
                       (keys (:cljs analysis)))
        sys-name (api/token-node (symbol (name (:value system))))
        new-node (api/list-node
                  (concat
                   [(api/token-node 'do)]
                   (when-not (existing (:value sys-name))
                     [(api/list-node
                       [(api/token-node 'def) sys-name system])])))]
    {:node new-node}))

(define-coordinates t e/R1-rect)

Why is this linting conditional on things existing prior to it?

My intent is to be able to let the user write:

(ns sicm.example
  (:require [sicmutils.calculus.manifold :refer [R2-rect]]))

(define-coordinates [x0 y0] R2-rect)

@borkdude another way to handle this would be

#_{:clj-kondo/ignore [:redefined-var]}
(define-coordinates [x0 y0] R2-rect)

#_{:clj-kondo/ignore [:redefined-var]}
(let* [G__43077
       (sicmutils.calculus.manifold/with-coordinate-prototype R2-rect ['x0 'y0])]
  (def R2-rect G__43077))

why not (declare R2-rect) ?

generate that inside the hook, you mean?

yeah, then that won't trigger a redefined var warning

interesting, that almost works, and the reason why not is because I didn’t think of it 🙂

almost because now we get this:

#'sicmutils.env/R2-rect is referred but never used

(ns sicm.example
  (:require [sicmutils.env:refer [R2-rect]]))

(define-coordinates [x0 y0] R2-rect)

you can just generate another usage after that

got it, so generate all the declares, and also a vector of all of the syms

yes

awesome, I’ll try that soon. thanks!

or you can generate something like potemkin import-vars which will then treat those defined vars as the imported vars with respect to arity, etc

I’m getting the hang of this. next @borkdude is to go document my hooks well and emit more custom warnings etc from the body

since there is built-in support for potemkin

@borkdude is it the case that to make that work, I’d again be in the position of having to know which ones were being declared for the first time and which were overwriting?

yeah I think so

(let [seq-node? (some-fn api/list-node? api/vector-node?)
        atom? (some-fn api/token-node? api/string-node? api/keyword-node?)
        tree (tree-seq seq-node? :children node)]
    (prn (remove (some-fn seq-node? atom?) tree)))

here is my “isolate via exclusion” method 🙂

This is a bug. You can ignore it with:

#_:clj-kondo/ignore
(even? ('a {'a 10}))

Also a bug. Ignore it with:

#_:clj-kondo/ignore
(fn [x]
  {:pre [(odd? x)]}
  (- x))