@UQE9SS4DP

{:lint-as {your.ns/defrecord+ clojure.core/defrecord}}

In this example, is your.ns the namespace that defines the defrecord+ macro or the namespace that is using it?

defining

I currently have this in my configuration under :lint-as as suggested, but that doesn’t seem to work.

(ns my-ns
  (:require [my-custom-record :refer [defrecord+]]))

; No lint issues here
(defrecord+ MyRecord [id data])

(ns my-other-ns
  (:require [my-ns :as mns]))

; unresolved var
(mns/make->MyRecord {:id id :data data})

Can you show your entire config? Make sure you put :lint-ason the top level

Yeah just to be clear, I’m not getting lint issues on the usage of defrecord+ its from the custom function it generates.

make->MyRecordis not defined by defrecord, that is map->MyRecord

That’s what I’m saying, defrecord+ defines non-standard constructor functions

ah ok. your option here is to write a custom config macro or hook. See https://github.com/clj-kondo/clj-kondo/blob/master/doc/hooks.md

Something which just expands into

(do (declare make->MyRecord) (defrecord MyRecord [] ...)

Ah ok, so I can set the :analyze-call for the defrecord+ macro, and I won’t need to configure :analyze-call for each of the make->X functions?

indeed

Excellent. That clears things up. Thanks!

there is :analyze-call but also :macroexpandwhich will probably be easier to start with, you can just provide a normal macro there, but it gives less precise warnings / locations

Gotcha, I’ll give it a try.

This question might be specific to clojure lsp or vscode, but can you recommend a good workflow for developing and testing these hooks?

Currently, use clj-kondo on the command line and insert printlns in the code for debugging, and then run it on examples

Yeah I had to smack myself when I realized I was working the really really hard way 🙂 using the command line was the way to go here! Hooks are working quite well for me now, thank you!

Though I ran into this issue that puzzled me. I thought it would be a no brainer to use :lint-as but that was not working, I had to use a custom hook which seems like it would do the same thing. Any idea here?

(ns shared-lib.io.utils)
(defmacro with-tmp-file* [[sym f] & body] ...)

;; Usage like:
(io-utils/with-tmp-file* [tmp-file "asset"] ...)

{:lint-as {shared-lib.io.utils/with-tmp-file* cojure.core/let}}

(defn with-tmp-file* [{:keys [node]}]
  (let [new-node (api/list-node
                   (list* (api/token-node 'let)
                          (rest (:children node))))]
    {:node new-node}))

@UQE9SS4DP a typo: cojure.core/let

should be clojure.core/let

😢 I need to catch up on sleep

:rolling_on_the_floor_laughing: thanks