is it possible to make clj-kondo ignore (comment) forms entirely?

@robert-stuttaford what are things that you would like to have ignored from comment forms? I usually want comment forms (= example code) to be free of errors as well

if i can switch off through configuration, then i can produce a report of all linting errors in production code. means it's possible to have 100% clean CI report and not be concerned with developer-time comments at all

i also like it on for comments, i use it that way a lot!

if i can have that, and figure out a way to lint rum components (i want this enough to contribute it), then we basically have a perfect workflow here!

can you try :skip-comments true?

that did something; i got less output than before. digging deeper...

yeah that seems to be working great!

I kinda forgot about that config.. nice that it's still working 🙂

https://github.com/borkdude/clj-kondo/pull/684 🙂

thank you sir. also, carve is -ing fantaaaaaastic 👏

@robert-stuttaford For rum, maybe this could work: https://github.com/borkdude/clj-kondo/issues/682

so then you can do {:lint-as {rum/def-foo clj-kondo.lint-as-macros/defn-1}}

that would work for a lot of weird def macros

it's certainly worth a try! i'd be totally ok with clj-kondo ignoring the rum mixins and just providing the usual linting for the args and body. the issue of course is instructing clj-kondo where the args can be found, and where the body starts!

the idea of that issue is to completely ignore the bindings, just registering the fact that is defines a var, so you won't get an unresolved symbol warning

that seems to cover the most weird def-macros that aren't natively supported yet

right

Has someone already find out what is required clj-kondo configuration for making compojure-api work with clj-kondo? Macros like this cause issues: https://github.com/metosin/compojure-api/blob/master/src/compojure/api/core.clj#L60

These macros are used like this (POST "/" request (handle-certificate-request request)). clj-kondo will then generate following error: error: unresolved symbol request

@mhjort there is built-in support for compojure.core; maybe you can use :lint-as?

see https://github.com/borkdude/clj-kondo/releases/tag/v2019.11.07

Thanks! I used same kind of :lint-asand :exclude for compojure-api macros. That helped

Compojure support works for basic cases but won't support Compojure-api restructure binding forms like (GET "/:id" req :path-params [id :- s/Str] ...)

in that case might just want to use :excludeyes

Reitit code will be easier to lint as it is just data 🙂

why does it say redundant form for #(do (prn %) (something %)) ? pointing at #( . i guess it's because #(do ...) becomes (fn [] (do ...)) ...

@robert-stuttaford that's probably joker? may I refer you to #joker for that?

$ clj-kondo --lint - <<<  '#(do (prn %) (something %))'
<stdin>:1:15: error: unresolved symbol something
linting took 42ms, errors: 1, warnings: 0

$ /usr/local/bin/joker --lint - <<<  '#(do (prn %) (something %))'
<stdin>:1:15: Parse error: Unable to resolve symbol: something
<stdin>:1:2: Parse warning: redundant do form

apologies, hard to tell where it's coming from!

you must get that a lot heh

not really, mostly from you 😉

😊

no worries, I was only kidding, just to be clear 😉

haha i'm not fazed. having a blast linting me codes