This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # adventofcode (9)
- # alda (2)
- # babashka (89)
- # beginners (86)
- # bristol-clojurians (1)
- # calva (54)
- # chestnut (2)
- # cider (18)
- # clj-kondo (19)
- # clojure (160)
- # clojure-brasil (2)
- # clojure-europe (6)
- # clojure-italy (8)
- # clojure-nl (46)
- # clojure-spec (52)
- # clojure-uk (45)
- # clojured (4)
- # clojuredesign-podcast (11)
- # clojurescript (15)
- # core-async (50)
- # datomic (41)
- # devops (3)
- # emacs (10)
- # fulcro (95)
- # graalvm (11)
- # graphql (3)
- # kaocha (1)
- # luminus (1)
- # malli (4)
- # off-topic (13)
- # overtone (3)
- # pathom (8)
- # re-frame (13)
- # reitit (10)
- # shadow-cljs (83)
- # spacemacs (2)
- # specter (9)
- # tools-deps (3)
- # vim (2)
@ericdallo Maybe you could provide some docs how to set this up as part of https://github.com/borkdude/clj-kondo/blob/master/doc/editor-integration.md, if you like
totally, one thing that we should do, its package a binary for the lsp-server, like
clojure-lsp already does(https://github.com/snoe/clojure-lsp/releases), which this, we only need to point to this binary on the
lsp-mode configuration and I can provide some docs how to do it.
I don't know if we can run the lsp-server on
lsp-mode from a jar, (I tried with no success :/) , maybe yes if we change
lsp-mode here(https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-clojure.el#L141) allowing one more lsp for clojure, the clj-kondo, like the docs recommend here(https://github.com/emacs-lsp/lsp-mode#registering-server).
What you think @borkdude?
@ericdallo What about just documenting what you did: make a wrapper script that calls
java -jar ... and register that wrapper script with lsp-mode?
It may not seem optimal, but for now it might be the best we have, and we can make it more polished if more people start using this?
it was my first try, but it didn't work, but i tested again pointing to the full path of the jar (not *~/*the/path/to/jar) and worked!
I guess a documentation on
clj-kondo.lsp's README teaching just to set the
lsp-clojure-server-command to run a
java -jar ... its good enough
I think it makes sense to include it in the clj-kondo repo and then I could link to it from the .lsp repo
Thanks @borkdude, I will try to use clj-kondo as a lsp server on emacs, and I can report the issues/improvements later
@borkdude Do you know if its hard to start implementing lsp features on
clj-kondo.lsp like rename, references and completion, similar how
clojure-lsp (https://github.com/snoe/clojure-lsp/blob/943188e7c64e2a5d635e8f3424feb67a34f0bc79/src/clojure_lsp/main.clj#L120) does?
I think that
clj-kondo is awesome and powerful, with these lsp features, it would be wonderful!
I would like to help implement, but i don't know how hard is and how to debug/test this as I implement? (PS: i don't know how LSP works, i know that its a message channel that expect specific headers and other things). I'm studyng
lsp4j, that i saw that you used to work with LSP. I hope I can help in some way
Interesting idea. I'd like to make/see a tool that can both be used with the binary and the LSP server. There are some ideas for this here: Once this is there, as a JVM lib, it can be hooked up to the LSP server as well https://github.com/borkdude/clj-kondo/issues/253
> This tool could potentially also fix some warnings by rewriting code. Maybe there has to be a separate issue for it btw.