Fork me on GitHub
#clj-kondo
<
2019-12-19
>
helios09:12:22

@borkdude from what I am gathering from here (https://github.com/borkdude/clj-kondo/commit/56e9a51bf1c87276e4ff9c928f5207d89f90dab7) clj-kondo should ignore the comments. Does that include (comment xxx) ? Because i think i'm still getting warnings for stuff inside such comments.

borkdude09:12:19

@helios a comment in rewrite-clj is something of the form ;;

borkdude09:12:30

clj-kondo does lint clojure.core/comment sections

borkdude09:12:53

you can turn it off, read the config docs

borkdude09:12:05

but personally I find it very helpful

helios09:12:08

ah ok didn't see it in the config yet, thank you 🙇

borkdude09:12:01

clojure.core/comment sections are often used as REPL buffers for experimentation, that is why I want linting there

helios09:12:02

I agree, but I introduced now a clj-kondo on a big project with a LOT of warnings. So i'm turning off everything ( 😄 ) until i get everything green. Then refactor stuff and re-enable it so it keeps being green

dominicm10:12:00

I use reviewdog to handle this. It only warns for things not on master.

helios10:12:11

with clj-kondo ?

helios10:12:28

thanks for the tip, seems interesting as well 😄

borkdude09:12:46

ok that makes sense. what you can also do is lint the current stuff to a status-quo.txt file and then view the diff between new changes and that file

helios09:12:05

ah, interesting idea as well

borkdude09:12:14

this is what I do myself in clj-kondo with new linters or changes to linters, to detect regressions

👍 1
borkdude09:12:50

you can also leverage the EDN / JSON output for more intelligent diffing / nicer reports

helios10:12:30

I'll look into that. Also I've seen a very interesting GitHub action (https://github.com/marketplace/actions/clj-kondo-checks)

helios10:12:39

Maybe i'll add it to the README

borkdude10:12:14

Maybe a new page called Build integration or CI integration would be nice, so we can add more stuff there

helios10:12:26

👍 will do that

borkdude10:12:21

yeah, you can ignore that. it's something @delaguardo was looking into I think

borkdude10:12:34

that step doesn't work with pull requests somehow

delaguardo10:12:15

Only with PRs from forked repositories

borkdude10:12:25

"CI integration" = "Continuous integration integration", maybe it's a bit double

borkdude10:12:00

Doesn't @helios have a forked repo?

helios10:12:13

I have a forked repo

helios10:12:42

I understand that is a bit double, but you're integrating clj-kondo with their continuous integration process 😛 Maybe I can find a synonym

borkdude10:12:25

yeah, maybe it's fine as it is. I like it better than "Build integration" since CI is most often a remote thing whereas build can also be local

borkdude10:12:47

I'm not sure if anything's wrong there

helios12:12:03

@borkdude thanks for managing overrides in a nice way. It was really good to create a ci-specific config.edn file and specify just the overrides for ci there 🙂 and keep the main clj-kondo config in the main config.edn file :thumbsup:

borkdude12:12:35

Ah, maybe that's worth mentioning in the CI docs 🙂

helios12:12:48

Why not 😄

borkdude13:12:17

@helios Congrats on the ClojureD talk btw. See you there!

helios13:12:50

thanks! 😄 Yeah looking forward to it