No letfn? 😞

https://nextjournal.com/plexus/advent-2019-part-18-exploring-bootleg

@oskarkv It's simply not implemented yet, I'll make an issue

https://github.com/borkdude/sci/issues/188

user=> (import '[java.time LocalDate])
nil
user=> (def d1 (LocalDate/parse "2019-11-11"))
#'user/d1
user=> (def d2 (LocalDate/parse "2019-11-12"))
#'user/d2
user=> (.isBefore d2 d1)
false

Hmm, adding these classes to the reflection.config adds about 7 MB (binary goes up from 30 MB to 37MB), is it worth it?

Is there any math lib or something, with pow etc?

Not yet, but adding java.lang.Math seems like a no brainer

Hehe

what OS are you on?

Linux Mint

@oskarkv https://2514-201467090-gh.circle-artifacts.com/0/release/babashka-0.0.43-SNAPSHOT-linux-amd64.zip

$ ./bb '(Math/pow 2 3)'
8.0

Nice!

Thanks

Now also merged this to master

Babashka, a native Clojure scripting tool, v0.0.43: Support for java.time.*, java.lang.Math, java.util.Base64 and java.lang.ProcessBuilder. https://github.com/borkdude/babashka/releases/tag/v0.0.43

@nate I guess this covers java.time well enough. People can now build their own babashka time libraries on top of the raw Java classes

ghadi was saying something in one of his talks about how some of the clojure wrappers for java.time had some "issues" (sorry, paraphrasing), so may be this approach is a good one to start with.

the java-time one seems needlessly complex to me

btw, bb recently seems to require java 8 to compile. i was getting away with java 11 up to not-too-long ago 🙂

at any rate, the latest commit builds here and all tests pass (with my usual tweak)

I think it's because of the unix-named classes which got renamed to jdk.internal.something.something

you might give that a try.

- Change the unix-named classes in babashka.impl.classes.clj to their JDK 11 equivalents

- Run lein with-profiles +reflection

- Then run script/compile

for reference, the error is:

Compiling babashka.impl.classes
Syntax error compiling at (babashka/impl/classes.clj:112:16).
Syntax error (ClassNotFoundException) compiling at (babashka/impl/classes.clj:112:16).
java.lang.UNIXProcess$ProcessPipeOutputStream

Full report at:
/tmp/clojure-929038568194110145.edn
Compilation failed: Subprocess failed

thanks for the hints. i'll take a look in a bit.

if you get that working, it's useful to add that info to the JDK 11 issue

@borkdude it seems like just removing the things that have unix in their name works

removing, but that breaks reflective access

ok, i didn't have much luck tracking down new names for relevant classes

i guess there are no tests to check reflection for the unix things then?

fwiw, the lein command i tried was:

lein do clean, with-profiles +reflection test

may be i got that wrong?

you first have to re-generate the json file with lein with-profiles +reflection run

then script/compile and then run the tests

with just lein test

ah i see -- your instructions lacked the string "run" so i guessed wrong 🙂

sorry

np -- am trying now 🙂

i have worked hard to forget leiningen usage 😉

all tests (tried both script/test and lein test -- former includes latter i presume) pass

is it the case that the unix-related classes were actually renamed -- not just subsumed into something else?

could be. in that case we can just delete them from the config I guess

can you test if this works with your version of bb? https://github.com/borkdude/babashka/blob/master/examples/process_builder.clj

thanks for the test

$ ./bb examples/process_builder.clj 
No matching method getOutputStream found taking 0 args for class java.lang.UNIXProcess [at line 11, column 20]

so the class still seems to be there?

if i add java.lang.UnixProcess back in to classes.clj and run the lein command, i get:

$ lein do clean, with-profiles +reflection run
Syntax error (ClassNotFoundException) compiling at (babashka/impl/classes.clj:110:16).
java.lang.UnixProcess

Full report at:
/tmp/clojure-15381430602635576939.edn
Error encountered performing task 'run' with profile(s): 'base,system,user,provided,dev,reflection'
Suppressed exit

i type-hinted proc in the example script with java.lang.Process and that seems to work

at least via lein -- am compiling to try via native-image

no luck

are you sure you used jdk11 in both lein (script/compile the jar step) + graal (script/compile the native-image step)?

no 🙂 i think i didn't. good point. will retry.

to be sure just set JAVA_HOME to the Graal JVM

my setup doesn't use JAVA_HOME usually -- what code will make use of that?

i added --report-unsupoorted-elements-at-runtime to get the compilation to complete. now the error i get at runtime for the process builder script is:

$ ./bb examples/process_builder.clj 
Invoke with MethodHandle argument could not be reduced to at most a single call: java.lang.invoke.Invokers$Holder.invoke_MT(Object, Object, Object, Object)

I think lein respects JAVA_HOME, but I'm not sure

yeah, I think you're running into the Reflector.java issue now

use --verbose

--verbose is already in the compile script on a side note, there are some options with = that don't have double quotes around them -- should i submit a pr for that?

is that problematic?

if --verbose is already there, the stacktrace probably points to Reflector.java

clojure.lang.Reflector that is

(i don't know if you remember, but we are warned by native-image [whether we have quote them or not] that they might be problematic)

regarding the "could not be reduced" message, what i pasted is all that i got, btw

./bb --verbose examples/process_builder.clj 

i'll remove the report at runtime and get more errors from the compilation

ah sorry

i misunderstood which verbose 🙂

np

https://pastebin.com/hLhgRNvx

i see the reflector

yeah, that's an issue that has to be fixed first if we're moving to jdk 11, it's already documented in the issue

graal doesn't play well with the dynamic usage of resolving a JDK 11 method in that class

I was thinking of releasing a small lib which copies the code from Reflector.java and removes the JDK8 reference and make the code for JDK 11 more static

and call it whatever/reflector-jdk11 or something

haven't looked at Reflector.java yet -- i guess i'll take a look

we can also just incorporate it directly in babashka I guess and compile it with lein (I think it's a good choice for graal projects, it can do all the stuff you need)

perhaps something relevant can be put in babashka initially and if it proves useful factored out later?

yes

Next version of babashka will have letfn (it's already on master) (cc @oskarkv)