It'd be interesting if clj-kondo could interpret metadata declarations and use them to control linting

I am running both joker and clj-kondo in spacemacs. There certainly is overlap between the two tools, and I am thinking of dropping joker. Do you think I will regret dropping joker?

@fiddlerwoaroof do you have an example?

@lee I use a small wrapper script that turns off some joker features and I use that together with clj-kondo. I could share it if you want

yes please @borkdude!

@lee:

#!/usr/bin/env bash

## turn off some joker features, so I can test clj-kondo better

/usr/local/bin/joker "$@" 2>&1 \
    | grep -v "unused" \
    | grep -v "unsupported binding form" \
    | grep -iv "unable to resolve symbol" \
    | sed -e 's/$/ (joker)/'
exit 0

I've put that in ~/Dropbox/bin and put that on the path before /usr/local/bin

in emacs I use both clj-kondo and joker with flycheck

maybe I should put this in a blog 😉

thanks! it might go well as a side-note in your docs where you talk about joker: https://github.com/borkdude/clj-kondo/blob/master/doc/editor-integration.md

well, it's kind of subjective what you want to suppress from joker, so it's not general advice, just how I happen to use it

btw, do you use emacs or some other editor?

@lee I'm fixing the quote-unquote bug right now. It results in a few less false positive while linting CLJS. e.g. here: https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/spec/alpha.cljc#L179 nice!

sweet!

I am using spacemacs

So maybe a blog post is better then. Personally I am only interested in heating from joker when it sees something that clj-kondo cannot see.

Have you seen: https://github.com/borkdude/clj-kondo/blob/master/doc/editor-integration.md#spacemacs

With joker you might also be able to use its config to turn some things off, but I found a wrapper script to be more flexible

and if I really want vanilla joker, I do: /usr/local/bin/joker

@lee Here's a fix for MacOS for the quote-unquote issue: https://4422-176829714-gh.circle-artifacts.com/0/release/clj-kondo-2019.07.06-alpha-SNAPSHOT-macos-amd64.zip

thanks, I shall try it shortly!

yes your spacemacs docs (with joker) are what my current setup is based on

I think I prefer the wrapper script as well

👍

maybe you could blog about it then 😉

kidding

maybe I should setup a blog someday!

so, that blog, if someone were to write it, might highlight what joker brings in addition to clj-kondo. As a newb, I’m currently unclear on that.

I think the most notable difference today is that joker is able to do some basic type checking on literals like (inc "string")

but I want to get that in clj-kondo as well

I'd say just use them both and turn off the overlapping parts with a script

so if you add that feature first, maybe the blog post advice on joker would change.

true that

might want to hold off a bit then

just tried quote-unquote fix, works great, thanks!

also joker is now much quieter thanks to your wrapper script. :thumbsup:

@borkdude, cljs compiler has a :fn-deprecated warning. I fail my build if I use anything deprecated - except when I am calling my own deprecated fn from a deprecated function or am testing my own deprecated fns. My build is currently awkward/brittle when handling these exceptions. Do you have plans to add deprecated checking to clj-kondo?

@lee sure! can you post an issue with some examples? would be happy to support it

cool! I think the clj only folks will probably find it useful too. I’ll try to get a git issue up today.

@fiddlerwoaroof the way to solve that right now is to start the argument names with an underscore: (fn [_arg1 _arg2])

@lee fix for clojure.test is + are: https://4435-176829714-gh.circle-artifacts.com/0/release/clj-kondo-2019.07.06-alpha-SNAPSHOT-macos-amd64.zip

@borkdude cool, the other use I thought of was for describing the syntax of custom macros.

can you give an example? note that the config already supports a bunch of things for custom macros: https://github.com/borkdude/clj-kondo/blob/master/doc/config.md#lint-a-custom-macro-like-a-built-in-macro https://github.com/borkdude/clj-kondo/blob/master/doc/config.md#exclude-unresolved-symbols-from-being-reported

One thought would be something like this:

(defmacro deftest
  {:clj-kondo/binds-globally '[test-name]}
  [test-name & cases])

Then, when the macro is used, clj-kondo could add the value of test-name to its dictionary of available names. I understand a lot of this can be done in the config file but I'd rather have the option to declare this stuff inline.

That is a little bit complicated, since clj-kondo might lint files where your deftest macro is used, but it doesn't yet know about the macro itself. E.g. when using editor integration, you only lint one file at a time

Sure, but there's already something like that with the --cache options?

e.g., IIUC, arity errors don't work correctly without a cache

clj-kondo can function correctly without a cache, but will just underreport arity errors when it doesn't know the arity of a called function with your example clj-kondo will overreport without a cache, something which I think is undesirable and hard to debug when users will report those false positives

in general, it's best to err on the side of false negatives

also, so far my impression is that most users don't like tool-specific annotations inside their code. I have considered it at one point for e.g. https://github.com/borkdude/clj-kondo/issues/241, but when a solution arose that required no changes to the code, that was the preferred option

I'm not completely dismissing the idea and I've also experimented with a namespace local config for some linters

but so far doing it via the config file is the preferred and most simple way

for testing, I sometimes use this:

(ns ^{:clj-kondo/config '{:lint-as {foo/foo clojure.core/def}}} foo)
(defmacro foo [_name & _body] ,,,)
(foo x)
(x 1)

hey there @borkdude, I submitted the my first clj-kondo feature request https://github.com/borkdude/clj-kondo/issues/338

thanks!

Now linting my project on circleci with clj-kondo! Fun stuff!