@lee I think you’re the first clj-kondo user that uses :default, it’s currently not recognized. I’ll make a fix, thanks

If you include :cljs in the last example it’ll probably work

fwiw, it's nice to use :default because of the potential for clojure clr support

yes, it should be supported

good to hear 🙂

@lee which OS are you using?

here is a fix for linux: https://4381-176829714-gh.circle-artifacts.com/0/release/clj-kondo-2019.07.06-alpha-SNAPSHOT-linux-amd64.zip and here is one for macOS: https://4379-176829714-gh.circle-artifacts.com/0/release/clj-kondo-2019.07.06-alpha-SNAPSHOT-macos-amd64.zip

I got that :default idea from our very own @sogaiu. I am not handling clojure-clr yet, but it is a step in that direction.

I am on macOS, and thanks! You are speedy!

BTW your clj-kondo logo is pretty awesome. It tells the story and spirit of the tool in smile inducing way.

I think I recommended :default to you too in the rewrite-clj channel 🙂

thanks, it was the result of a nice interaction with nikitonsky on twitter

well, my continued thanks to you both

or maybe I recommended it to someone else, but I vaguely remember this for the same reason as sogaiu mentions: if more targets are added, you're already future proof

yeah it’s a good tip!

just tried snapshot build you provided, works like a charm, thank you!

thanks for reporting and testing

rewrite-clj has maybe uncovered another clj-kondo issue. In a macro, a variable only referenced with quote unquote is reported as unused. For example, clj-kondo gives an unused binding warning for new-meta for the following:

(defmacro import-fn
  "Given a function in another namespace, defines a function with the
   same name in the current namespace.  Argument lists, doc-strings,
   and original line-numbers are preserved."
  [src-sym target-name target-meta]
  (let [vr (resolve-sym src-sym)
        m (meta vr)
        m (resolve-fn-location m)
        new-meta (dissoc target-meta :name)
        protocol (:protocol m)]
    (when (:macro m)
      (throw (ex-info "potemkin clj cannot import-fn on a macro" {:symbol src-sym})))
    `(do
       (def ~(with-meta target-name (if protocol {:protocol protocol} {})) (deref ~vr))
       (alter-meta! (var ~target-name) merge '~new-meta)
       ~vr)))

hmm, I see

would '~new-meta be the same as (quote ~new-meta)?

might work as a workaround, nevertheless, it's a false positive

yes, that work-around does the trick.

do you want a git issue for this one?

sure!

right now clj-kondo doesn't analyze everything that follows a literal quote for usages, but in backticks this apparently doesn't hold

will do!

I have another one for you. When including a macro like so in a cljc source:

(ns forborkdude
  #?(:cljs (:require-macros [forborkdude :refer [my-macro]])))

#?(:clj
   (defmacro my-macro[x]
     `(str "hello there, " ~x)))

(my-macro "borkdude")

@lee what's the reason you're only defining it for :clj?

your lib doesn't support self-hosted CLJS?

hmmm…

nonetheless, it's a false positive that kondo should support

self-hosted CLJS is on my todo list… still need to learn details on how macros work there.

for self-hosted you'll need to remove the :clj conditional and then it should just work, unless you're using JVM specific things

well that’s cool.

i can git issue this one too if you’d like

yes please!

done!

thank you ❤️

and thank you too for all your help and a linter that sparks joy

@lee here's a fix for the self-require issue: https://4388-176829714-gh.circle-artifacts.com/0/release/clj-kondo-2019.07.06-alpha-SNAPSHOT-macos-amd64.zip

thanks, that fixed the issue.

ok, no more clj-kondo warnings under my src tree, time to move on to test!

rewrite-clj tests make heavy use of the clojure.test.are macro. Does clj-kondo want to do any linting on these? Contrived silly example:

(deftest t-for-borkdude
  (are [?a ?b]
      (is (= ?a (dec ?b)))
    1 2
    10 11
    14 15))

Oh wait, your default config has some handling for are: https://github.com/borkdude/clj-kondo/blob/67966d2c38a813c909371f5c08b64a742c6806e4/src/clj_kondo/impl/config.clj#L44

ah… it is missing the cljs.test variant.

If I add the following to my .clj-kondo/config.edn my cljc files no longer produce warnings:

{:linters
 {:unresolved-symbol
  {:exclude [(cljs.test/are)
             (cljs.test/is [thrown-with-msg?])]}}}

I’ll git issue this one.

@lee Not yet, thanks for the git

added issue https://github.com/borkdude/clj-kondo/issues/335

I frankly don’t much about them yet, but rewrite-clj uses defspec in some tests. I don’t think clj-kondo handles these puppies yet?

what's defspec?

hmmm… I assumed it was a common thingy. I’ll get back to you.

http://clojure.github.io/test.check/clojure.test.check.clojure-test.html#var-defspec

I’ve not learned about test.check yet.

you can use :lint-as for this to treat it as clojure.core/def

thanks I shall try that!

{:lint-as {foo.bar/defspec clojure.core/def}}

that worked, thank you!

Updated docs for the snap package manager. You might want to try it: https://github.com/borkdude/clj-kondo/blob/master/doc/install.md#snap-linux (cc @jr0cket)