Fork me on GitHub
#cider
<
2023-09-15
>
nivekuil17:09:05

is there anything blocking https://github.com/clojure-emacs/clj-refactor.el/issues/517? not sure what the replacement for pkg-info would be

1
vemv17:09:47

I'll work on this today Perhaps I had forgotten about it since we didn't get more reports. Also, I've stuck to Emacs 26. Either way - will get it to a better state!

vemv18:09:07

Done https://github.com/clojure-emacs/clj-refactor.el/pull/549 clj-refactor.el 3.9.2 has been cut. It will be visible into MELPA within a few hours, or if you use Git dependencies, you can simply pull :)

❤️ 1
nivekuil06:09:44

cljr-version: Symbol's value as variable is void: cljr-version -- I get this on repl connect, should https://github.com/clojure-emacs/clj-refactor.el/blob/eb8c75bb5d0c4bbffb7adab1ad3084da50b93ece/clj-refactor.el#L3432 be a hard coded defconst like cider-version?

👀 1
vemv09:09:31

I'll check it out. I thought this was working because I can both cider-connect and cider-jack-in. Anyway, this code path only is hit when you try running an older refactor-nrepl version. 3.9.0 is required. Try bumping it? Thanks!

vemv10:09:40

I have applied your suggested fix. It will be visible into MELPA within a few hours, or into Git master right now

nivekuil16:09:31

ah I forgot to bump that. wish we could inject middleware on connect (maybe we can now with repl.deps?) thanks for the fix

vemv17:09:20

Thanks to you! You can also specify "RELEASE" as a version, it will resolve to latest. A bit loose of an specification, but we will very rarely have breaking changes.

nivekuil17:09:52

wow, I never knew that