@benedek i'll give that a go, thank you!

it looks like that was it!!

well, that fixes that problem. i've got a new problem:

ERROR: Unhandled REPL handler exception processing message {:op clean-ns, :prefix-rewriting false, :debug false, :path [], :libspec-whitelist [^cljsns ^slingshot.test ^monger.joda-time ^monger.json], :prune-ns-form true, :session a8d7a0bb-203e-4372-84fb-4cbc40cd80af, :id 14}
java.lang.AssertionError: Assert failed: (seq path)
	at refactor_nrepl.ns.clean_ns$clean_ns.invokeStatic(clean_ns.clj:38)

This could be an actual bug with clean ns

Strange your path is empty

So should be something in the elisp code...

i'll share news soon 🙂

Ta

@benedek, both path and (buffer-file-name) are null here https://github.com/clojure-emacs/clj-refactor.el/blob/master/clj-refactor.el#L2652 when i have when instead of unless here https://github.com/clojure-emacs/clj-refactor.el/blob/master/clj-refactor.el#L2649

well it can be if the buffer does not have a file related to it.

only those should be filtered out i guess….

any chance you know what buffer is this?

is it normal that clj-refactor wants to analyze the project every time i do find-usages ?

depends on your config.

you can set (setq cljr-warn-on-eval nil) so it won’t ask you but analyze in the background

if you let it analyze it will cache the results tho

so next time it analyzes it should not take long as it only builds ASTs for changed files

so to summarize: yes, but it should just use the already cached ASTs for most (not changed) namespaces

Is there any way to tell clj-refactor to exclude a specific directory (eg. test) when it tries to analyse all the files ?

i don’t think there is at the moment. all clj files get analyzed on your classpath

alright. we have some custom readers in a project, and they’re referenced in some test files. clj-refactor is not able to parse that

you can set cljr-ignore-analyzer-errors to t

so clj-refactor will ignore errors in those ns-s and carry on with find-usages/rename symbol

leaving these nses out obviously. kinda best effort really...

that is not any worse than excluding some file tho either.

alright. that works for me. thanks!

wlc

@benedek: well, i'm running project-clean, where the file isn't in a buffer. with-temp-file, remember

or, otherwise, i don't understand enough about this to know what i'm talking about 🙂