Fork me on GitHub
#calva
<
2022-11-29
>
Joe Douglas10:11:35

👋 Reported https://github.com/BetterThanTomorrow/calva/issues/1981 yesterday and thought I'd take a stab at it (mostly because it's now blocking my work and not just an inconvenience on my personal project). The behaviour seems to work as expected on the dev branch (forked and cloned this morning), any ideas what's going on?

Joe Douglas14:11:52

Update: I've reproduced it and figured out what's going on

orestis09:11:19

FWIW, I'm seeing this with a plain architecture too

🙏 1
Max22:11:02

After this is resolved, is this the kind of thing calva could have tests for? As a heavy user of “run current test”, this regression made my day a little sadder today 😞

😩 1
pez23:11:54

Yes, it is a thing we could add a test for. We have an e2e testing framework set up, that today is used to check that we can start a repl and connect to it, and some other simple thing. Please check it out, @U01EB0V3H39 and don't hesitate to ask us for help, and check if you think you could add this particular test.

pez23:11:59

Also, @U01EB0V3H39. I have been occupied with other things today and haven't tried the PR, which I am pretty sure is fixing the issue. If you could test it and report on the PR, that would be awesome. Then we can get the fix out early tomorrow.

Max19:12:45

Sorry, just getting back to this now. I can add investigating adding a test to my todo list but it might be a little while before I get to it, my personal life became unexpectedly interesting last Friday

pez19:12:20

I hope in a good way?

Max19:12:05

In an immediately difficult but hopefully nice eventually way?

🚼 1
🤞 1