Great stuff as always! However at my work we've had a problems when using java.net.net.HttpClient with respect to network timeouts. For example request timeout does not cover receival of the body: https://bugs.openjdk.org/browse/JDK-8258397 Not sure if this can be solved perfectly at a higher level such as babashka/http-client or not (or just mitigated).

I have not looked super close at it, but my personal preference as of now is to just stay away from http://java.net.http.HttpClient :-/

@UGJE0MM0W The workaround that occurred to me also is mentioned here: > A possibility for the caller is to make use of the CompletableFuture API (get/join will accept a timeout, or CF::orTimeout can be called). IIRC - in that case, it will still be the responsibility of the caller to cancel the request. babashka http-client isn't going to fix JDK issues, unless the workaround is super obvious

babashka.curl and httpkit will still be available options in bb though

@UGJE0MM0W

user=> (let [resp (http/get "" {:async true})] (deref resp 1000 ::too-late))
:user/too-late

user=> (let [resp (http/get "" {:async true})] (deref resp 1200 ::too-late))
{:status 200,

That's an OK-ish workaround I think. One problem we also had is that it takes a long time before a HTTP/2 connection is marked bad/dead. Requests kept piling onto the same dead connection, so a bunch of requests (eventually) timed out, thus we had a flood of timeouts. HTTP/2 is the default as far as I know. Using HTTP/1.1 would be better in this case.

@UGJE0MM0W I don't think so:

user=> (:version (let [resp (http/get "" {:async true})] (deref resp 1000 (delay (do (future-cancel resp) ::too-late)))))
:http1.1

I think so:

Returns the preferred HTTP protocol version for this client. The default value is HttpClient.Version.HTTP_2

I wonder why I'm getting :http1.1 - I'll dig deeper

perhaps because the other side doesn't support http2?

anyway, you can set it using :version :http1.1

other site: I guess so. I see that you are doing some http-version stuff as well

I updated the docs to set the version

Anyway... My experience on an unstable network (Azure container instances) + http2 (default) is unfortunately not very good with http://java.net.http.HttpClient. I'd be hard pressed to recommend it in such a setting. I also cannot recommend Azure container instances per se. The problem lies with the JDK of course, not babashka/http-client. I have no idea if babashka.curl/httpkit is better. clj-http is http1.1 default + timeouts that are respected AFAIK, which is what I've stuck with.

If that works for you, keep using it :)