@nwjsmith do you have a jira account?

In any case I just created https://dev.clojure.org/jira/browse/TCHECK-135

@gfredericks yes! I'm nwjsmith in Clojure JIRA, and I've signed the CLA

Feel free to assign that to me. I got the tests running on the latest CLJS last night, but the approach I took might require a larger overhaul of how the tests are currently run. Do you mind if I make some substantial changes in that area?

@nwjsmith if you're confident that your changes are making the orchestration more idiomatic for lein-cljsbuild setups, then that's fine with me

I don't use modern cljs much at all so I can't easily judge those things

I'm confident that's the case. Will be taking my lead from Om's test running and some stuff we have internally

@nwjsmith I see your user page, but the full-name-based dropdown that jira gives me on the ticket edit page does not have your name under 'Nate Smith' or anything similar; seems like a bug, but perhaps you can assign it to yourself? /cc @alexmiller

Weird. Not sure if this helps but here's a ticket I'm the reporter on: https://dev.clojure.org/jira/browse/CLJ-2079

Can't assign myself unfortunately.

haha great

I'll just keep it assigned to myself ¯\(ツ)/¯

@nwjsmith if there are any other contrib projects with cljs tests, those would be an interesting comparison point

Good call, looks like tools.reader is a good example

core.async and spec.alpha sound plausible also

@gfredericks @nwjsmith your user wasn’t in the right groups to do edit/assign - I fixed and assigned that ticket

Thanks Alex!

re cljs tests, note that the official build file for all contrib projects is the pom.xml (as that’s what the CI build uses)

and the pom.xml uses clojure-maven-plugin which doesn’t know or understand cljs (at least in the version we are forced to use due to jvm and maven versions)

many projects have parallel project.clj files which people use to run cljs tests locally

a few projects have started to experiment with ways to integrate these - I think data.xml is the most robust example of that

👍 thanks @alexmiller

it’s done by integrating the cljs tests into the clojure tests directly

in this area https://github.com/clojure/data.xml/tree/master/src/test/clojurescript/clojure/data/xml

uses nashorn I believe

Oh interesting @nwjsmith if you go the nashorn route I think it'd be good to maintain the ability to easily run with node as well

@alexmiller oops I think I got assigned to the wrong ticket, should be TCHECK-135

oops! reading comprehension fail. fixed.

Thanks

I'll look into integrating the CLJS tests with the Clojure ones as well.

getting the cljs tests to run via maven is a nice-to-have; if it's much harder, just getting clojurescript upgraded is fine