Clojurians
#cljs-dev
<
2017-11-17
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen19:11:10

Looking at CLJS tickets this afternoon, feel free to link ones you think I should consider

dnolen19:11:23

@thheller did you submit that perf patch you mentioned a couple of weeks ago? The emission thing?

dnolen19:11:50

@olivergeorge I applied your :stub fix, sorry for the delay

dnolen19:11:21

@anmonteiro this patch seems fine to me - https://dev.clojure.org/jira/browse/CLJS-2394

thheller19:11:33

@dnolen I did not. I was testing in lein repl which disabled a bunch of JIT stuff. when testing with a proper setup it was a much smaller difference, barely 1%.

dnolen19:11:56

thanks for info

anmonteiro19:11:15

@dnolen looks fine to me

dnolen19:11:16

great thanks for taking a look

thheller21:11:50

@dnolen if you get to it https://dev.clojure.org/jira/browse/CLJS-1439 is pretty straightforward

dnolen21:11:27

will take a look

mfikes21:11:41

@dnolen https://dev.clojure.org/jira/browse/CLJS-2377 would be nice to clear up sometime over the next month or so, given that Java 9 is out. (For example macOS users that do brew cask install java end up with Java 9 and the ClojureScript Quick Start fails without the fix in CLJS-2377.)

mfikes21:11:30

(It is possible to run QuickStart as it stands now under Java 9; you just need to add an extra option to the java command line.)

olivergeorge22:11:52

Thanks David, excited to see that in.

dnolen23:11:28

@mfikes oh nice, is the Quick Start issue mentioned in the ticket? I missed that bit of urgency

favila23:11:50

@thheller Re: https://dev.clojure.org/jira/browse/CLJS-2396 Could this potentially be used to distinguish the various compilation phases in a cljc file? macro-time cljs (self-hosted cljs), macro-time clj (clj-hosted cljs), and runtime cljc and cljs? This is pretty obtuse right now. see https://github.com/cgrand/macrovich

mfikes23:11:18

@dnolen Nah. Quick Start failing is not mentioned. Thinking about it more, it probably affects anyone trying to use ClojureScript with Java 9. (Was just worried a little about prospective users giving up on a first bad impression.)

dnolen23:11:26

of course, let’s add a comment about the Quick Start issue to the ticket

dnolen23:11:36

I would have looked at it more closely if that had been mentioned

mfikes23:11:40

Updated CLJS-2377. Yeah, the previous description made the problem appear to be more esoteric than it really is.