This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-11-18
Channels
- # beginners (84)
- # boot (21)
- # cider (12)
- # cljs-dev (13)
- # cljsrn (3)
- # clojure (169)
- # clojure-dusseldorf (2)
- # clojure-gamedev (6)
- # clojure-germany (1)
- # clojure-russia (15)
- # clojure-serbia (4)
- # clojure-spec (16)
- # clojure-uk (4)
- # clojurescript (51)
- # core-async (1)
- # datomic (23)
- # emacs (16)
- # figwheel (1)
- # fulcro (60)
- # hoplon (8)
- # lein-figwheel (3)
- # leiningen (1)
- # luminus (4)
- # lumo (43)
- # off-topic (4)
- # re-frame (17)
- # rum (37)
- # shadow-cljs (21)
- # test-check (13)
- # vim (14)
@gfredericks
The patch ended up being much smaller that I had thought https://gist.github.com/nwjsmith/edd1ce97b9e5334ac3cbc49a77ffb339
I'm trying to track down the other part of that ticket though. I can't seem to find any reader conditionals related to :/
in the tests. Did that already get fixed up?
@nwjsmith do you have the latest master?
I've attached the patch to the ticket. Do I need to fiddle with the JIRA workflow of the ticket at all?
No -- you got both of the :/ things?
cool, taking a look now
@nwjsmith looks great! will push as soon as the tests pass on my end and then close the ticket thanks again
No problem. Thanks for your help and let me know if there's anything else you'd like me to take a crack at
TCHECK-125 looks manageable, if you're interested
I'd wrap all the defmethod
s in an if
that checks if clojure.test/report
is a MultiFn
or whatever that class is, and if it's not then just print a warning to *err*