Fork me on GitHub
#test-check
<
2017-11-18
>
nwjsmith18:11:56

@gfredericks The patch ended up being much smaller that I had thought https://gist.github.com/nwjsmith/edd1ce97b9e5334ac3cbc49a77ffb339 I'm trying to track down the other part of that ticket though. I can't seem to find any reader conditionals related to :/ in the tests. Did that already get fixed up?

gfredericks18:11:34

@nwjsmith do you have the latest master?

nwjsmith18:11:43

I see it now

nwjsmith18:11:38

I've attached the patch to the ticket. Do I need to fiddle with the JIRA workflow of the ticket at all?

gfredericks18:11:53

No -- you got both of the :/ things?

nwjsmith18:11:52

Yeah, both of the keyword-symbol-serialization-roundtrip and edn-roundtrips tests

nwjsmith18:11:00

and they both pass

gfredericks19:11:18

cool, taking a look now

gfredericks19:11:27

@nwjsmith looks great! will push as soon as the tests pass on my end and then close the ticket thanks again

nwjsmith19:11:28

No problem. Thanks for your help and let me know if there's anything else you'd like me to take a crack at

gfredericks19:11:38

TCHECK-125 looks manageable, if you're interested

gfredericks19:11:37

I'd wrap all the defmethods in an if that checks if clojure.test/report is a MultiFn or whatever that class is, and if it's not then just print a warning to *err*