"saving the page" I assume you mean saving the file?

https://code.thheller.com/blog/shadow-cljs/2019/08/25/hot-reload-in-clojurescript.html is the only thing I can link you to in general

otherwise need more specific code examples. don't know what you are doing, so can't give specific answers

Sorry for being non informative enough 😉 Basically I render a map. When saving, hot reloading shows blank page, but evaluate the code on the REPL automatically renders the map on the page. My intializers are:

(defn home-page []
  [:<>
   [items-list]
   [map-container]])

;; -------------------------
;; Initialize app

(defn mount-root []
  (d/render [home-page] (.getElementById js/document "app")))

(defn ^:export init! []
  (mount-root))

the map components look like this:

(ns coffee-tlv.components.map-container
  (:require ["mapbox-gl" :as mapbox]))


(defn map-container []
  [:div#map])


(set!
  (.-accessToken mapbox)
  "pk.eyJ1IjoiaXRheWRyZSIsImEiOiJja2RlczU5bmIwcDlzMnducmVuMDQ4cWlyIn0.BSyB9nVoIsnazX2PeUyPyg")

(def tlv-map
  (new
    (.-Map mapbox)
    #js
    {:container "map",
     :style "",
     :center #js [34.79 32.07],
     :zoom 15}))

this is not how you use non-react things with react/reagent

look up the docs for refs

I created this example for pdfjs a while ago https://github.com/thheller/reagent-pdfjs

its pretty much the same for mapbox

this being the important parts https://github.com/thheller/reagent-pdfjs/blob/master/src/main/demo/app.cljs#L19-L22

also see https://docs.mapbox.com/help/tutorials/use-mapbox-gl-js-with-react/

Taking a look, thanks a lot!

..but bundle size is now 29MB 😄 It should be ~4-5MB

Argh. After manually deleting all cached files and previously generated output I still get these warnings with output-feature-set :es8 . Does someone have advice what to try next?

Ha! Among the aforementioned warnings there was also a single extern problem that caused the release build to blow up. I guess those errors from Closure don’t matter 🤷

Ok, I did more methodological tests and following seems to be the case • “Parse error. name not recognized due to syntax error.” happens when outputting < :es8 • With :es8 I don’t see the errors and my build & app works ◦ I had an unrelated extern problem which I was able to fix Last question is that are there any known problems with es8 as output feature set? I mean other than “doesn’t work with IE11". 😉

I checked from analytics and during past 3 months we’ve had one (1) IE11 visitor. Maybe the World is ready for es8..?

Also, thanks for shadow Thomas! I just migrated my main project from good old lein-figwheel + webpack and it’s been a joy to work with shadow. 🙏

not sure what would cause this error but in the past the closure compiler had issues processing some @ directives in comment blocks. the files from OL seem to be full of them. I'm guessing it has some issues with this

/***
     * @type {LayerOnSignature<import("../events").EventsKey>}
     */

unsure how es8 is related to any of this though

Oh, interesting. Could be that my testing wasn’t methodological enough. 😅 I’ll try one more time with default :output-feature-set

the default is :es2020, so dunno why downgrading fixes anything 😛

but maybe it does something "more" that it otherwise doesn't

Ah 😄 Ok I had completely wrong assumption

I thought it was ES5 or something

But I’m probably remembering how CLJS is complied through Closure

es5 is the default in regular CLJS, not in shadow-cljs

doesn't feel right so use es5 in 2023 😛

I see. 😄 I should maybe just RTFM

everything compiles just fine for me importing ol/layer/Layer

In the docs there’s > By default the generated JS output will be compatible with ES6 and all “newer” features will be transpiled to compatible code using polyfills. probably outdated?

yeah outdated

I also upgraded shadow from 2.20.15 => 2.20.20 in the process. Dunno if this could explain some of the wierdness

possible. that included a new closure compiler version.

Anyway, now it’s working and my code is running happily in production. 🙂 Thanks!