Would it make sense to add a top-level config, something like :ignore-warnings-in-ns #{ns.*} instead of adding the :ignore in :warnings-as-errors? We also have a dep that causes warnings and we can't really do anything about them, so I'd prefer just to ignore those warnings altogether and then let all other warnings throw errors.

I was thinking about adding something like :defaults {:compiler-options ...} at the top level. so config that applies to all builds

given the popularity of react-bootstrap, i'm hoping someone can help. when i require react-bootstrap:

(ns myproject.core
  (:require ["react-bootstrap" :as bs]))

TypeError: (0 , _uncontrollable.default) is not a function

yes, that is caused by a version conflict

i've tried with both 0.8.0 and 0.9.0-rc1 in my shadow-cljs.edn :dependencies

hmm?

hmm. and like last time, triggering a hot-reload fixes the problem

thats a version conflict on the npm package not the CLJS side

so package.json

Hi everyone, still relatively new to cljs and shadow but I just wanted to confirm something, given this code:

(ns demo.foo)
(defn hello [who]
  (str "Hello, " who "!"))
(defn generate-exports []
  #js {:hello hello})

:builds
 {:lib {:target      :node-library
        :output-to   "package/lib.js"
        :exports-fn  demo.foo/generate-exports}}

got it. and i think last time you said there's no easy solution, as juggling multiple versions on the NPM side is crazytalk

@miguelb that's pretty small all things considered, and way smaller when automatically gzipped by the server/browser.

@miguelb yes. there isn't much use in checking the size of dummy code since most of it is cljs.core and stuff

think of it like that lib included immutable-js + lodash or so

ah ok, I’m starting to evaluate writing libraries in cljs for use at work so I wanted to see how much overhead I would be bringing along

@joshkh @thheller thanks again for the input

@thheller i think last time you did some digging on my behalf. any advice for identifying the conflict myself?

@miguelb IMO writing libs in CLJS for JS is not tenable right now, exactly because most of the time you don’t want the overhead of CLJS core data structures and standard library in your library code

^ even when the target is a nodejs library? is 98kb a big deal server-side?

sorry, not server side

it would be for browser

though none of the libraries I was thinking about doing have any browser specific in them.

@joshkh even for Node.js I would ask: why? writing libraries in CLJS is not it’s forte

I’m often far more tempted to write libs in JS and a small wrapper in CLJS, than the other way around

CLJS and it’s standard library and data structures really only shine in application development

thanks for sharing, and i do agree that writing one-off cljs libs for any js based project is not ideal.

it’s tough when you want to transition to using Clojure but your app is written in JS already

that being said i've had success replacing large portions of js based projects with self contained cljs projects, but they were full apps with their own api, and ended up being the same file size in the end.

@lilactown that’s exactly the situation i’m in

@lilactown I disagree. you can write libraries pretty well in CLJS. just not those typical micro libraries with one function in them. writing something bigger that would bring in something like immutable-js+lodash etc in JS wouldn't be much different.

the problem only comes when you include multiple of those libs in one JS project

@joshkh if you wouldn't mind asking that question again somewhere others can find it too (http://ask.clojure.org, stackoverflow or so)

I can give you some hints how to track it down

great idea, and thanks @thheller. i was already finding it frustrating not being able to find my previous question on slack.

indeed. I know I tracked it down last time but also can't remember

for when (if ever) you find the time, thanks again @thheller https://ask.clojure.org/index.php/8665/compiling-shadow-projects-transitive-dependency-conflicts

Trying to get react-select to work but it's not

/js/cljs-runtime/shadow.js.js:36 shadow-cljs - failed to load module$node_modules$$emotion$core$dist$core_browser_cjs
shadow.js.jsRequire @ /js/cljs-runtime/shadow.js.js:36
shadow$provide.module$node_modules$react_select$dist$react_select_browser_cjs @ /js/cljs-runtime/module$node_modules$react_select$dist$react_select_browser_cjs.js:3
shadow.js.jsRequire @ /js/cljs-runtime/shadow.js.js:34
shadow.js.require @ /js/cljs-runtime/shadow.js.js:55
eval @ /js/cljs-runtime/doublethedonation.integrations.records.js:9
goog.globalEval @ mp360.js?updated=20190805:827
env.evalLoad @ mp360.js?updated=20190805:2174
(anonymous) @ mp360.js?updated=20190805:2633
/js/cljs-runtime/shadow.js.js:36 shadow-cljs - failed to load module$node_modules$react_select$dist$react_select_browser_cjs

might be the same problem I just described here https://ask.clojure.org/index.php/8665/compiling-shadow-projects-transitive-dependency-conflicts?show=8666#a8666

(and thanks for the response!)

react-select loads fine for me, so most likely a version conflict with some other lib you have

it seems to be failing on emotion/core but nothing else uses it

i'll mess around

where is the rest of the error? there should be more?

ie. actual exceptions? not the yellow parts in the console log?

ok it had to do with the fact that inferno-compat doesn't have React.createContext

but now when i require ["react-select" :refer [Select]]

and do

[:> Select {:options [{:value "Chocolate" :label "Chocolateee"}]}]

it's creating

<undefined options="[object Object]"></undefined>

well you are on your own if you use custom setups like inferno and stuff

don't know anything about react-select. you might need to pass more options?

and dunno if reagent converts converts nested props?

might need clj->js?

had to use ["react-select" :default Select]

javascript is mad confusing

yeah and it'll get worse before it gets better 😞

https://darongmean.com/post/react-native-cljs-es6-import-export/

oh it's from https://shadow-cljs.github.io/docs/UsersGuide.html#_using_npm_packages nice