Hola

hi everybody. A question concerning shadow-cljs intergration in CIDER. I am working on a mixed CLJ/CLJS project (deps.edn + shadow-cljs). Following shadow-cljs manual, I end up with 3 REPL: - CLJ REPL: where I run the http server and play with CLJ files - CLJ REPL: the one connected to shadow-cljs watch [...] - CLJS REPL: the sibling of the above Is this the expected situation? cider-find-var doesn't seem to be working, but I can interact with the browser from the CLJS REPL.

hey. I don't use emacs myself so I can't really comment. sounds correct though

no idea what cider-find-var is or does though

thanks @thheller. cider-find-var is a jump-to-definition.

yeah sorry no idea how that works. maybe its talking to the wrong REPL?

I'll investigate further, thanks. 🙂

@manuel you don't have to launch separate cljs repls. I just run the watch command, and connect to the NREPL server that's printed out using cider connect. After that, to get the browser repl working, I run (shadow/nrepl-select :build-name) in that repl buffer window

when you navigate to the project in the browser, you'll see "JS runtime connected"

---- I have a library that uses deps and shadow, I want to use it from another project, but the library has npm dependencies, how do I package those deps so when I use the library I don't get npm install errors?

@haywood fantastic, thanks

@haywood create a deps.cljs and add {:npm-deps {"that-lib" "1.2.3"}}

deps.cljs and not deps.edn?

deps.cljs must be on the classpath and yes deps.cljs

ohh, ok

I had tried adding that to deps.edn to no avail, will look into that

must be part of the lib. deps.edn usually isn't

@haywood cider-find-var is not working yet, though

do you have cider in a global deps file?

I have this in my ~/.clojure/deps.edn cider/cider-nrepl {:mvn/version "0.18.0-SNAPSHOT"}

here's the project: https://github.com/manuel-uberti/boodle

I have that in shadow-cljs.edn

oh, so it's just find var? everything else is working?

yes 🙂

gotcha, let me see if mine is working

mine now gives: user-error: ‘cider-find-var’ requires the nREPL op "info" (provided by cider-nrepl)

thanks @thheller that worked 🙂

@manuel huh, yea mine works once connected to the browser repl

I don't have any special cider or repl stuff in my shadow project

I do have this in my .clojure/deps.edn refactor-nrepl {:mvn/version "2.4.0"}

not sure if that's necessary

@gleisonsilva I finally had some time to properly trace the re-frame-10x warnings you reported a few days ago https://github.com/Day8/re-frame-10x/issues/219

pretty much the same issue as https://github.com/nathanmarz/specter/issues/267

this is great, @thheller! Thank you very much

@haywood thanks again. I added refactor-nrepl to my shadow-cljs.edn, and cider-find-var is working now.

great, we did it!

I also removed anything CLJS related from my .dir-locals.el, BTW.

Question, I am trying to get a node repl for a :node-script but I get:

node bin/migrate-event-store
Error: ENOENT: no such file or directory, open '/home/arichiardi/git/laputa/.shadow-cljs/builds/migrate/dev/out/cljs-runtime/goog.debug.error.js'
    at Object.fs.openSync (fs.js:646:18)
    at Object.fs.readFileSync (fs.js:551:33)
    at global.SHADOW_IMPORT (/home/arichiardi/git/laputa/event-store/bin/migrate-event-store:47:15)
    at /home/arichiardi/git/laputa/event-store/bin/migrate-event-store:3006:1
    at Object.<anonymous> (/home/arichiardi/git/laputa/event-store/bin/migrate-event-store:3115:3)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)

(ooops sorry for the ping 😸)

does it exist? maybe removed .shadow-cljs dir without recompiling?

it does not exists no

-rw-rw-r-- 1 arichiardi arichiardi    5671 Nov 13 10:04  goog.debug.console.js
-rw-rw-r-- 1 arichiardi arichiardi   19066 Nov 13 10:04  goog.debug.debug.js
-rw-rw-r-- 1 arichiardi arichiardi    1713 Nov 13 10:04  goog.debug.errorcontext.js
-rw-rw-r-- 1 arichiardi arichiardi    1797 Nov 13 10:04  goog.debug.error.js
-rw-rw-r-- 1 arichiardi arichiardi   13935 Nov 13 10:04  goog.debug.formatter.js
-rw-rw-r-- 1 arichiardi arichiardi    4312 Nov 13 10:04  goog.debug.logbuffer.js
-rw-rw-r-- 1 arichiardi arichiardi   26315 Nov 13 10:04  goog.debug.logger.js
-rw-rw-r-- 1 arichiardi arichiardi    6131 Nov 13 10:04  goog.debug.logrecord.js
-rw-rw-r-- 1 arichiardi arichiardi    2404 Nov 13 10:04  goog.debug.relativetimeprovider.js

oh sorry yeah it is there

at this full path /home/arichiardi/git/laputa/.shadow-cljs/builds/migrate/dev/out/cljs-runtime/goog.debug.error.js?

uhm...nope

it seems like it expects in the parent of the project folder

the project path is /home/arichiardi/git/laputa/event-store/.shadow-cljs/builds/migrate/dev/out/cljs-runtime/goog.debug.error.js

I must have messed something up

check the :output-to file generated by the build

yeah that ends up correctly in :output-to "./bin/migrate-event-store"

no .. check the content of the actual file

oh

it'll have something like var SHADOW_IMPORT_PATH = __dirname + '/../../.shadow-cljs/builds/script/dev/out/cljs-runtime'; at the beginning somewhere

yeah var SHADOW_IMPORT_PATH = __dirname + '/../../.shadow-cljs/builds/migrate/dev/out/cljs-runtime';

I am on 2.6.23 in this project

and if (__dirname == '.') { SHADOW_IMPORT_PATH = "/home/arichiardi/git/laputa/event-store/.shadow-cljs/builds/migrate/dev/out/cljs-runtime"; }

it seems like it does not go in the if

its not supposed to

but it seems to go up one level too much

__dirname is HEY /home/arichiardi/git/laputa/event-store/bin

I put a console.log

try :output-to "bin/migrate-event-store"

lemme try

it works with the above

but...

uhm

:output-to is always relative to the project root so ./ is pointless

guess I should add a validation for that or properly normalize the path

kk good to know

so the scripts runs now but it does not connect to any REPL, I am never sure we added support for :node-script REPLs 😄

they always had support

soooo should the script stop with something like

{:target :node-script
                    :main laputa.event-store.migrate/-main
                    :output-to "bin/migrate-event-store"
                    :release {:compiler-options {:optimizations :advanced
                                                 :source-map true}}}

it probably does but it might be a problem in my script...which has option validation with failures

yeah probably that's what happens

so never mind about the second issue

and really thanks about debugging and solving the first

Today is debugging day, so I have this:

$ cat .shadow-cljs/config.edn 
{:node-modules {:install-cmd ["--network-concurrency" "1" :packages]}}

but I still see running: yarn add ... packages

is that the right place where to put that conf?

oh I see it is in $HOME...but I also can put it in shadow-cljs.edn it seems

seems to work, definitely nice

shadow-cljs - config: /home/arichiardi/git/laputa/scrutinize-fn/shadow-cljs.edn  cli version: 2.7.3  node: v8.12.0
shadow-cljs - starting via "clojure"
running: yarn add --network-concurrency 1 ....packages....

yeah shadow-cljs.edn or ~/.shadow-cljs/config.edn

don't think .shadow-cljs in the project dir is a useful location

agree 😉

When we do (shadow/release :prod) for the production build, do we need to do compression ourselves?

compression?

gzip? yes, that is done typically by the webserver

as gzip -9 js-file.js

I mean when doing the release of the assets

I am pushing this to s3

and within the bucket I obviously see the uncompressed js

not sure how s3 handles it but I'd expect it to automatically compress

just check the request the browser makes