Shadow-cljs fails to import PIXI.js with ["pixi.js" :as [Pixi]]

Uncaught TypeError: Cannot redefine property: default$
    at Function.defineProperty (<anonymous>)
    at index.js:23
    at Array.forEach (<anonymous>)
    at Object.shadow$provide.module$node_modules$pixi_js$lib$core$index (index.js:21)
    at shadow.js.require (VM2328 shadow.js.js:51)
    at Object.shadow$provide.module$node_modules$pixi_js$lib$index (index.js:19)
    at Object.shadow.js.require (VM2328 shadow.js.js:51)
    at phlox.main.js:10
(anonymous) @ index.js:23
shadow$provide.module$node_modules$pixi_js$lib$core$index @ index.js:21
shadow.js.require @ VM2328 shadow.js.js:51
shadow$provide.module$node_modules$pixi_js$lib$index @ index.js:19
shadow.js.require @ VM2328 shadow.js.js:51
(anonymous) @ phlox.main.js:10

hmm weird what pixi is doing there

I define the default$ for cljs compat since cljs munges default to default$

I can take that out for JS->JS requires though since they won't need that

won't get to it until next week though

hmm, what is it that Pixi is doing that causes this to choke?

from the screenshot it is doing a forEach copying the properties from _math with was required above

which it also did for _const

since both have a default$ that blows up

I think at least, didn't look at the actual code

the code already skips the default property but it doesn't know about default$

looks like that is caused by babel? in the repo we have:

export * from './math';

var _math = require('./math');

Object.keys(_math).forEach(function (key) {
  if (key === "default" || key === "__esModule") return;
  Object.defineProperty(exports, key, {
    enumerable: true,
    get: function get() {
      return _math[key];
    }
  });
});

yeah looks like babel

Is it possible to specify the host ip for the dev server? I'd like the server to listen on 0.0.0.0 instead of localhost.

@mjmeintjes yes :http {:host "0.0.0.0"} in the top level, same as :builds

oh wait dev server

I think I forgot to add the option for those

Yeah, just tried it but it seems to only change the ip for the shadow-cljs server, not the dev server.

yeah, it defaults to localhost and isn't configurable

It would make sense to add a :http-host key under devtools?

will fix it to use the main http :host config by default and :http-host in devtools

you probably only want to configure it once so it would make sense to configure use the top level :host

It is strange, but I used to be able to access the dev server from other machines in a previous version, but since I upgraded it seems to only listen on localhost.

2.0.105 to 2.0.122

oh that might be an unintended side effect of switching the http server

removed aleph and switched to undertow recently to optimize startup time and get http2 support

I see. No worries. Do you want any help adding the host option?

I can take care of it if you don't mind waiting a few days

pretty busy currently. should be next week.

No rush. I'll see if I can figure it out and maybe create a PR.

I wanted to tune the dev servers anyways, so I can do that as well then https://github.com/thheller/shadow-cljs/blob/master/src/main/shadow/cljs/devtools/server/dev_http.clj#L125

I could just switch the default to 0.0.0.0, seems way more reasonable

don't really need to restrict it to localhost

I agree regarding the default, especially since it was that way before. Thanks.

I was surprised to see undertow as a dependency of shadow, knowing there's a http server built-in makes more sense.

https://github.com/thheller/shadow-cljs/wiki/REPL#embedded-dev-only I'm trying to do this, it seems that shadow/start-worker is not in devtools.api. I tried watch but ran into an issue where runtime/instance-ref was not set, so I figure I'm doing something wrong.

@mjmeintjes I pushed [email protected] which changes the default host back to 0.0.0.0

@dominicm if you are using the embedded version you need to manage the runtime somehow

Great! I love the fast release cycles you have. Thank you.

(shadow.cljs.devtools.server/start!) to start and stop!

start-worker is just dev the wiki is a bit old

but it should still be there

@thheller start-worker got moved into a different namespace I think. There's a get-or-start-worker in api.clj

indeed. I renamed that to watch to match the CLI

the start! fn will launch the “runtime” which runs in a background thread(s)

watch in particular needs that

https://github.com/thheller/shadow-cljs/blob/fafa15c0f0f5bca722853a8a3061f5b3ed81507d/src/main/shadow/cljs/devtools/api.clj#L48-L63 I'll mimic this structure, but where the shutdown is elsewhere.

the others start a “light” runtime so they don’t need that

can’t do with-runtime for watch since it needs to keep running in the background

Yeah, exactly. But I presume it covers all the steps I need to take?

no with-runtime is not suitable for watch

start! is

I mean, it shows me the functions I need to call in order to do setup, no?

no, it is a “light” runtime

I'll read start!, I'm not interested in using the shadow http server in this case.

watch needs that to reload files though

Oh, why is that?

the clients connect to a websocket for REPL/reloading

that server is started by start! not by with-runtime

Is there a version which starts only the websocket server (or just the core requirements).

with-runtime will use the server created by start! though so it won’t launch a new runtime

if you don’t have any other http servers configured they won’t be started

but yes the websocket server is a core requirement

Dec 28, 2017 10:36:35 PM org.xnio.Xnio <clinit>
INFO: XNIO version 3.3.6.Final
IllegalArgumentException XNIO001001: No XNIO provider found  org.xnio.Xnio.doGetInstance (Xnio.java:255)

Hmm, looks undertow related

never seen that before, probably a missing dependency

are you on java8?

I really don't recommend running shadow-cljs alongside all your other JVM stuff

I'm on java8, yes.

too many headaches dealing with conflicts and such

I'm thinking it could be an issue with tools.deps.alpha not resolving dependencies correctly.

google says https://stackoverflow.com/a/31117740

if you have mvn installed you can clj -Spom and mvn dependency:tree

maybe that has some useful info

❯ boot -d thheller/shadow-cljs -B with-cp --write --file /tmp/bootcpfile
Retrieving maven-metadata.xml from  (6k)
Retrieving shadow-cljs-2.0.124.pom from  (7k)
Retrieving xnio-nio-3.3.6.Final.pom from  (6k)
Retrieving shadow-cljs-2.0.124.jar from  (376k)
Retrieving xnio-nio-3.3.6.Final.jar from  (113k)

Yeah, the boot classpath file has 2 entries for xnio, and tools.deps.alpha only has one.

tools.deps definitely has some unresolved issues. there was another issue where it picked an ancient version of clojurescript over a more current one

Might be because the dependency has a scope sigh

I think boot uses pomegranate which lein and shadow-cljs also use

or basically all CLJ tools except tools.deps, so yeah there are going to be issues. it is still alpha after all 😉

yeah, for sure.

Direct dependency resolved it, opened TDEPS-26 to track

I've got:

(shadow.server/start! {})
(shadow/watch
{:build-id :hoop/app
                       :target :browser
                       :output-dir "public/hoop/js"
                       :asset-path "/public/hoop/js"
                       :modules {:main {:entries [pro.juxt.hoop.app]}}})

I see a jar-manifest directory

hmm?

it is in "public/hoop/js"?

can't see the build?

Not on the filesystem, no. Just used find to check.

nothing matching "hoop" or ending with ".js"

(well, nothing not mine matching hoop!)

did it complete?

user=> (def stop (pro.juxt.krei.core/watch))
shadow-cljs - server running at 
[:hoop/app] Configuring build.
#'user/stop

do you call stop! immediately watch watch?

krei.core/watch returns a function, which calls (shadow.server/stop!). So, no.

can you try compile* with your config?

dunno why it would stop printing

but no idea what you are doing either

if you are messing with *out* or anything else the output would go elsewhere

I'm not touching *out*

I'd suggest trying without the complicated stuff first

call start!

call watch

see what happens

user=> (shadow.cljs.devtools.server/start! {})
shadow-cljs - server running at 
:shadow.cljs.devtools.server/started
(shadow.cljs.devtools.api/compile* {:build-id :hoop/app
                       :target :browser
                       :output-dir "public/hoop/js"
                       :asset-path "/public/hoop/js"
                       :modules {:main {:entries '[pro.juxt.hoop.app]}}} {})
[:hoop/app] Compiling ...
AssertionError Assert failed: (cljs-util/is-file-instance? cache-root)  shadow.cljs.devtools.config/make-cache-dir (config.clj:115)

I'll have to figure out this cache-root stuff later, I'm probably not specifying something I should be.

hmm that might just be an error since it expects a config file

Maybe I need to merge in a default config then

no it does that by default

too tired, going to bed. gn8

I don't see any merge if I explicitly pass an empty map,

Night