Hi, I've got this warning in shadow-cljs release app:

-> Compile CLJS: devtools/hints.cljs
WARNING: You required cljs-devtools library in a project which is currently compiled with :optimizations :advanced.
         You should remove this library from non-dev builds completely because it impedes dead code elimination.
         The best way is to use :preloads compiler option: .
         To silence this warning please set :silence-optimizations-warning config key to true.
         More details: .

@cmal not sure, maybe :compiler-options {:silence-optimizations-warning true}?

or do you want it in dev only?

then :devtools {:preloads [devtools.preload]}

Thanks. If I already have :devtools {:preloads [re-frisk.preload] :autoload true} in shadow-cljs.edn, should I change it to :devtools {:preloads [[re-frisk.preload] [devtools.preload]] :autoload true}?

:preloads [re-frisk.preload devtools.preload]

Thanks.

Another question. I am doing shadow-cljs watch app and then shadow-cljs cljs-repl app but I got this in cljs-repl:

[1:1]~cljs.user=> (+ 1 1)
There is no connected JS runtime.

yeah your app needs to be loaded in the browser or so

OK. Thanks.

if you just want a repl you can do shadow-cljs node-repl

OK

2.0.50 introduced this error when building maria:

[:live] Configuring build.
[:live] Build failure:
target-fn shadow.build.targets.browser/process not found
{:target :browser}
ExceptionInfo: target-fn shadow.build.targets.browser/process not found
	clojure.core/ex-info (core.clj:4744)
	clojure.core/ex-info (core.clj:4744)
	shadow.build/get-target-fn (build.clj:180)
	shadow.build/get-target-fn (build.clj:153)
	shadow.build/configure (build.clj:198)
	shadow.build/configure (build.clj:185)
	shadow.cljs.devtools.server.worker.impl/build-configure (impl.clj:121)
	shadow.cljs.devtools.server.worker.impl/build-configure (impl.clj:90)
	shadow.cljs.devtools.server.worker.impl/fn--22666 (impl.clj:208)
	shadow.cljs.devtools.server.worker.impl/fn--22666 (impl.clj:200)
	clojure.lang.MultiFn.invoke (MultiFn.java:233)
	shadow.cljs.devtools.server.util/server-thread/fn--22550/fn--22551/fn--22555 (util.clj:162)
	shadow.cljs.devtools.server.util/server-thread/fn--22550/fn--22551 (util.clj:161)
	shadow.cljs.devtools.server.util/server-thread/fn--22550 (util.clj:146)
	clojure.core.async/thread-call/fn--7892 (async.clj:442)
	java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1142)
	java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:617)
	java.lang.Thread.run (Thread.java:745)

uhm?

that definitely exists

may be bad AOT cache, try deleting target/shadow-cljs/aot-classes

wonder how it got into that state

@mhuebert [email protected] should fix the JS issue you ran into yesterday. https://github.com/thheller/shadow-cljs/issues/124

wonder how the other thing happened though

21023 events is that normal in the shadow-re-frame demo?

its firing events like crazy?

guess it calling render for every time it wants to update the counter

by doing so triggering another render?

can’t tell if that might be related due to an update I did?

no, that’s not normal

but i know what the cause would be

easy fix

so not something I may have just caused by the update?

I don’t think so. it is related to how component-paths are read

i had fixed it, but recently my patch was merged into re-frame-trace and one aspect of it may have not been applied/merged correctly

good to know. I was getting worried that my update didn’t work properly

i will build with latest update now

to make sure

and then test my other project with that bug from yesterday

not important but WARNING: You required cljs-devtools library in a project which is currently compiled with :optimizations :whitespace.

shouldn’t this warning only occur on :release?

hmm its by cljs-devtools not by me

i see.

hmm ok it checks :optimizations which it expects to be :none

I guess I can set that so it doesn’t complain

in shadow-cljs :optimizations is only used in release mode and otherwise ignored

i wouldn’t worry about it

this project is a special case / demo of dev-time tools

i just pushed an update to shadow-re-frame, for me the events count normally

you could also set :release {:compiler-options {:optimizations :whitespace}} which would only set that option for release

but I will still force it to :none since other macros might use that as well

not something I ever recommend doing but people do weird things

yeah the fix from yesterday looks like it works

counter still going crazy for me

on the deployed version or locally?

& which browser?

no deployed version is fine, just my local version

ah wait

:source-paths ["src"

                ;; for development, checkout re-frame-trace and re-view into sibling directory,
                ;; or remove these entries:
                "../re-frame-trace/src"
                "../re-view/re-frame-simple/src"]

I might have old checkouts of those

maybe remove those dirs

use the version from clojars

yeah thats it

phew

:whitespace warning should also be gone in next update

extern annotation with ^js is pretty easy and intuitive

still getting this browser/process not found error after rm -rf target

it does not happen if I compile the :live build by itself, only when multiple builds at the same time

and it is order dependent, npx shadow-cljs watch trusted live fails, npx shadow-cljs watch live trusted works

downside to loading bootstrap stuff via inline <script> tags is that errors show up as coming from <anonymous> locations:

TypeError: Cannot read property 'cljs$core$IFn$_invoke$arity$1' of undefined
    at Function.cljs.spec.test.alpha$macros.instrument.cljs$core$IFn$_invoke$arity$4 (<anonymous>:248:95)
    at Function.cljs.core.apply_to_simple.cljs$core$IFn$_invoke$arity$6 (/js/compiled/cljs-runtime/cljs.core.js:13067:10)

@mhuebert you keep finding the good bugs. npx shadow-cljs watch trusted live should now work in [email protected]

race condition when loading the target fn, so two builds with the same :target would cause one to fail.

i’m trying to get a circleci thing running for maria

if i can figure this config out, it would be nice to get it to run whenever shadow-cljs updates 🙂