Hi, I created a little gist here

https://gist.github.com/dharrigan/0de573b78ea5d7c151be58cc727a9569

that works very very well for me 🙂

thanks @U11EL3P9U, having similar utils in projects, SHOULD be part of reitit

With that running in my local setup, I can change any route, handler whatever...re-eval the function and things magically just work 🙂

(re-eval the handler function, or something that it calls, not the static-ring-handler/reply-friendly-ring-handler...)

exactly that. would you like to PR a helper into reitit.ring?

@U055NJ5CC 🙂

also, support both arities, 1 & 3

yes, atm, it's all synchronous for me 🙂

here’s what I have:

(if dev-mode
  (fn
    ([request] ((create-handler) request))
    ([request respond raise] ((create-handler) request respond raise)))
  (create-handler))

maybe a reitit.ring/dev-handler function that takes a 0-arity fn to create the actual ring-handler?

letmeseewhatIcanrustleup 🙂

thanks a lot!

I've improved my little demo, seen here to use this way of using the ring-handler.

Maybe you might find something useful there 🙂

You need to add a decoder

(def muuntaja-instance
  (m/create
   (-> m/default-options
      (assoc-in [:formats "application/json" :decoder-opts] {:decode-key-fn csk/->kebab-case-keyword
                                                             ;;<<???>> #(java.time.LocalDate/parse %)
                                                             })
      (assoc-in [:formats "application/json" :encoder-opts] {:encode-key-fn csk/->camelCaseString
                                                             :date-format "yyyy-MM-dd"})


      #_(assoc-in
       [:formats "application/json" :encoder-opts]
       {:date-format "yyyy-MM-dd"}))))

How do i add decoder?

@UK0810AQ2?

In the schema https://github.com/metosin/malli#coercion

I really need to get off my ass and write a library to add those

Yeah i can't figure it out

(malli/coerce :int "invalid" mt/string-transformer)

Syntax error compiling at (src/highlights/server.clj:56:3).
No such var: malli/coerce

Yeah malli has no coerce, you need decode

(def date-decode (malli/decoder [:fn #(java.time.LocalDate/parse %)] mt/string-transformer))

(date-decode "2022-10-10")

=> "2022-10-10"

That doesn't do what you want it to, hang on I'll whip up a complete example

The malli docs are dense but all the information is there, I just had to read them several times slowly 😞

But you need to understand what schema properties are, how decoders are specified via properties, and how to use them

Truth is i am using malli for validation in other places. I wanted to reuse same schema.

[:map {:closed true} [:match-id [:fn {:description "Match id", :swagger/default "7e1840af-7758-4baa-957b-cc1bdd753303", :swagger/type "string", :swagger/format "uuid", :error/message "Invalid match-id"} #function[highlights.validation/valid-uuid-as-str?]]] [:date [:fn {:description "Date when the match happened", :swagger/default "2022-10-10", :swagger/type "string", :swagger/format "date", :error/message "Invalid date"} #function[highlights.validation/valid-date-as-str?]]]]

i didn't know i had to specify decoders or how to 'plug' them

Thanks a lot for taking the time to look at this

Fn schemas are evil for this reason, but you can plug decoders into them too

(m/coerce
 [:fn
  {:decode/string #(java.time.LocalDate/parse %)
   :decode/json #(java.time.LocalDate/parse %)}
  #(instance? java.time.LocalDate %)]
 "2022-10-10"
 (mt/string-transformer))
; => #object[java.time.LocalDate 0x2bbd77fb "2022-10-10"]

@U055NJ5CC where is coerce located at? It's not in malli.core?

in core, just unreleased 😉 https://github.com/metosin/malli/blob/master/CHANGELOG.md#unreleased

reitit uses m/decode, same results here.

coerce thows on error

Can the function returned by coercer have continuation arity, too?

like what?

@U45SLGVHV here you go

(require '[malli.core :as m] '[malli.transform :as mt])
(import java.time.LocalDate)

(def local-date
  (m/-simple-schema
   {:pred #(instance? LocalDate %)
    :type-properties
    {:decode/string #(try
                       (LocalDate/parse %)
                       (catch Exception _ %))}}))

(m/decode local-date "2020-10-01" mt/string-transformer)

you can add any and all other properties to the type-properties map

Oh little bit of cheating, i thought i was going mad because i couldn't find it my v0.9.2 of malli Thanks a lot. Basically adding

[:fn
  {:decode/string #(java.time.LocalDate/parse %)
   :decode/json #(java.time.LocalDate/parse %)}
  #(instance? java.time.LocalDate %)]

@UK0810AQ2 thanks for this but how does it differ from the above?

maybe we should finish adding the https://github.com/metosin/malli/pull/545 to malli, copy-pasting what is needed between projects :thinking_face:

we can start adding properties, such as the expected pattern, min and max date, those are for specific instances of the schema. Additionally we could add more things to the schema, put it in a registry, and make it less opaque

I learned some stuff since then wrt time schemas, I can do it better now

they should all be able to take properties

want to finish the draft?

I'll open a new MR

@U055NJ5CC @UK0810AQ2 why am i allowed to make wrong input in swagger and input doesn't get to be red? also if i try execute it fails on the server. If i change uuid to something bad it doesn't even allow me to 'execute'

https://github.com/metosin/malli/blob/master/src/malli/json_schema.cljc#L46

What matters isn't the predicate function, but how it's externalized over json schema to the swagger UI

Thanks i get that but i found weird behaviors. I've been on this whole day so maybe fatigue is taking it's toll. I will step out and try again tomorrow Thanks both for your time and effort

I think i figured it out for date 🙂 You were right i had to look on how description was done in swagger.

[:fn {:swagger/description "Date when the match happened"
               :swagger/default "2022-10-10"
               :swagger/type "string"
               :swagger/format "date"
               :swagger/pattern #"^\d{4}\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])$"
               :decode/string #(java.time.LocalDate/parse %)
               :decode/json #(java.time.LocalDate/parse %)
               :error/message "Invalid date"}
          date?]

Regarding UUID it seems to be that as soon as you put [:fn... in your schema you need to provide decoders and helpful defaults are out. So you need to specify all json-schema goodies you need.

Thanks for pointing me out to right direction!

🙇

👍 related to :fn - it has no type so you have to tell everything yourself. There is an old issue of type-tagging schemas easily, which would allow you to say: [:fn {:type :int} (fn [x] …]] and all schema applications (transforming, generators, json-schema, …) would know it’s an :int.

plan is to work on that early next year.

#'app binding might work for me :thinking_face:

See here: https://clojurians.slack.com/archives/C7YF1SBT3/p1671110957164779

Ah, that's quite neat 😄 Thanks!

I'm updating my example (on github) to use this

with added bonus of malli validation 🙂

Here you go:

https://github.com/dharrigan/startrek-donut

A major update. Includes malli validation, tests, transactions, reloadable routes...

rollbackable transactions during testing...

I'm tired now. I go to bed 🙂

Updated with generators and more tests!