It seems that it is not loading the goog.math.long.js currently. That's probably causing the error.

OK. Something is expecting the output to be in directory "app" – but it is written to "out".

=> using output-dir "app" gives a new error 🙂

Now it's concatenating an absolute path with a URL. Maybe this is configuration related.

That error has to do with symbolication. The actual error is still

ERROR  ReferenceError: Property 'Long' doesn't exist, js engine: hermes

OK. It's the Long.fromBits in goog.math.long.js that is causing the issue. Maybe Hermes does not have that.

as far as I remember this is due to hermes not suporting es6 features like const

that file just hpappens to be the first file trying to use them

set :compiler-options {:output-feature-set :es5} in your build config

OK - thanks! any ideas on the output dir? We had out previously and it has worked earlier but now it does not.

whats in your build config?

:output-dir

Previously I had :output-dir "out" – now I have :output-dir "app"

If I have output-dir "out" I get an error when it tries to resolve goog.math.long.js

and did you update the .js file including them?

Yeah, using "app" metro works

(I updated refs to out => app from relevant places)

I don't mind having the output in app so it's not a big deal, just threw me off since this had worked before.

shadow-cljs doesn't care where you put it

it just writes to whatever :output-dir you tell it

about special meanings in react-native I have no clue, so can't comment on that

Yes, the output gets written to out as before, but for some reason metro gets "app" from out of nowhere and tries to resolve from it

=> switching shadow-cljs to output to "app" makes it all work again

@U05224H0W switching to es5 did not work – it still fails on

ERROR  ReferenceError: Property 'Long' doesn't exist, js engine: hermes

shadow-cljs doesn't write any output to out if you don't configure it

Yes, i know 🙂

if there are files getting created there it is not shadow-cljs

No, there was nothing like that happening

then I don't know. never used react-native or hermes

Yes, it seems that Hermes is missing something essential that goog.math.long expects to have

I can just opt out from Hermes for the time being, that is not a problem

So, the only question remains to be solved is that why does react native expect to have stuff written in "app" when we have been using "out" for many years without issues. This is not a shadow-cljs issue probably and I can live with just changing the output dir 😄

Thanks for your work on shadow-cljs. It's such a great tool 🙂

I had same issue awhile back and what Thomas advised for you helped me https://clojurians.slack.com/archives/C0E1SN0NM/p1665753992908259?thread_ts=1665725322.539589&cid=C0E1SN0NM

maybe something is cached for you?

I did reset caches et al, and switching back made it work again. I can live without Hermes for the time being. Thanks for the info though!

No idea if this is happening in shadow or cljs compiler

someone mentioned this a few days ago but didn't open an issue I think

this is indeed a bug yeah

I can. Should it go to shadow-cljs issue tracker? And is that enough of a description, or should I make a minimal repo that shows the problem with package.json and everything?

Also noticed than in working cases too the resulting JS code is a bit different. The old style creating shadow.js.require() calls and then referring to objects with names like modules$node_modules$$DefaultExport$index.default, while the new one will skip the require and refer to shadow.js.shim.module$$DefaultExport$default. I tried looking at the issues around the time this changed in the docs (Feb 20), but didn't find anything, so I wonder what the implications are. At first I thought that both styles would result in identical code, so I guess the translation is happening at a different place?

should be easy to reproduce. I think I already know the problem so just an issue as a reminder is enough

Got it, filing

https://github.com/thheller/shadow-cljs/issues/1075. Thanks for the quick confirmation