remind me what's the correct way for negotiating html responses please?

i made a custom muuntaja formatter for text/html

(def negotiator
  (muuntaja/create
    (assoc-in muuntaja/default-options
              [:formats "text/html"]
              (html-format/format))))

mounted it on my routes as

{:data {:muuntaja negotiator
              :middleware [format-middleware
                           require-tmb-session]}})

the :muuntaja/response key is correctly set to {:format "text/html", :charset "utf-8", :raw-format "text/html"} but it's not injected in the response map

so the response goes out as application/octet-stream

am i missing something?

i thought format-middleware should handle the Content-type header if missing

@vale what is your endpoint returning as :body? by default, only collection bodies are encoded. This is quite lame imo and there is an issue for it: https://github.com/metosin/reitit/issues/122

oooh

i'm returning string :body

a) you could override that default in the negotiator b) switch-case on the negotiated content-type in a custom mw c) let't resolve the issue

for an immediate solution, could you point me to how to override said default?

currently i have a format an encoder and a decoder defined for the negotiator

@vale set the [:http :encode-response-body?] to (constantly true) in Muuntaja options

thanks, that did the trick!

gonna look at that issue the weekend!