Fork me on GitHub
#cljdoc
<
2018-11-19
>
Vincent Cantin03:11:01

The “page not found” page needs to have the message “Page not found” written on the top, otherwise it does not look like the user arrived there via a broken link. At the moment, it looks like a legit search page.

martinklepsch09:11:50

Fair point, I'll try to fix this later

Daw-Ran Liou16:11:39

@martinklepsch are you working on this already? If not I can also fix it.

martinklepsch16:11:03

Working on other stuff still so feel free 🙂

Daw-Ran Liou16:11:19

Ok cool I'm on it

Daw-Ran Liou16:11:54

I submitted the PR https://github.com/cljdoc/cljdoc/pull/218. Though the 404 page could be further improved (e.g. adding a link to the home page) this PR has the explicit “404 - Page Not Found” message on the top.

👍 4
Daw-Ran Liou16:11:36

@martinklepsch I’d like to learn more about the frontend. I found this one seems to be a good start: https://github.com/cljdoc/cljdoc/issues/99. What do you think?

martinklepsch16:11:44

Sure, that's a good one

martinklepsch20:11:34

@vincent.cantin @dawranliou your PRs are deployed, thanks again for contributing 🙂

🙌 8
Vincent Cantin01:11:04

I plan on keeping contributing, I have a lot of free time ATM as I am unemployed.