Fork me on GitHub
#pedestal
<
2023-06-05
>
hlship17:06:48

The main change to watch out for is related to path parameters in routing: https://github.com/pedestal/pedestal/issues/588

phill23:06:53

It seems to say, that if a program uses path parameters then it won't work anymore? That's a big breaking change. Is there guidance for a workaround?

phill23:06:26

And, p.s., does it merit a major version number change?

hlship23:06:41

It's actually the opposite; an existing program will have set up its own logic to decode path parameters, but now that (by default) happens automatically and you may decode path parameters twice, which is wasteful and occasionally will cause errors (for instance, if a % is encoded as %37 it will decode once to % then fail when decoding the second time (either erroring, or consuming two hex digits that follow it).

hlship23:06:46

So it can be subtle.

hlship23:06:08

The intention is that this decoding should always have happened, but it didn't and there wasn't a test so nobody realized for a while.