hey guys, any React experts here? Can someone help me here with css-transition? I have a table, whenever user clicks on a col-header I am changing class of sort icon “fa-sort-desc”/“fa-sort-asc". Now I would like to animate that thing. Tried using vanilla css, by attaching keyframe animation to specified classes. But it only works very first time, when clicked on a header. I tried using CSSTransitionGroup - still no luck, there’s no DOM update happening, - class gets removed and a different one added

Anyone has any ideas how get it to work?

Maybe I can do something right there in onClick handler?

CSSTransitionGroup should only be needed if the element is entering or leaving dom.. Sounds like your element is staying in the DOM just changing the className

I asked a while back if an ident's second value could be a vector (essentially creating a compound key). The answer was no. But the only things that seem to not support it are the prospective specs (https://gist.github.com/swannodette/842326cbb6ab35e0d1aa51fb41c5697e) and Datomic.

I understand why Datomic lookup refs can't support compound keys, but it would be really helpful to allow them for other users.

unless there's some upcoming work in Om that they'll actually be incompatible with

Case in point: on CircleCI, we have orgs which are identified by an org name and a VCS provider (GitHub or Bitbucket). It would be nice to continue to use that pair as the key, rather than introduce a new id key just to satisfy a spec that's based on conforming to Datomic's technical limitations.

(unless I'm missing a theoretical issue, in which case I'd love to know what that is)

I suppose it comes down to our API, which is parameterized by a VCS provider and an org name, not by an opaque id. We prefer that design, and so it would be convenient (possibly necessary?) for our idents to match.

@peeja: even though idents like that are not officially supported, I think your app will work if you use something like that

from what I remember, I don’t think it’ll break anything?

I might be wrong

Well, I'd rather not do something so fundamental that's not supported.

but in a toy app, it does appear to work

I suggest you open an issue with your use case so that it just doesn’t get forgotten

What I'm asking is: would the team consider calling it supported (but inadvisable if you're using Datomic on the backend)?

might even be a good suggestion to support it, but I’m not the person to say

Er, where's the Om JIRA again? Is it linked from somewhere?

https://github.com/omcljs/om

Oh, I guess I'm thinking of filing ClojureScript issues.

not JIRA, just github repo

@peeja I also found it useful to use maps as the second element of an ident a while back. I didn’t know about this spec. I think it would be worth filing an issue to discuss it at least

And using maps worked without any bugs for me

@chris-andrews: Yeah, someone else on our team also suggested maps, and that seems like an even better idea. I've filed an issue: https://github.com/omcljs/om/issues/737

@peeja Awesome, thanks for starting that discussion. I chimed in on your issue.

Thanks!

For those using om next, or really writing any code that involves client-side querying, how are you addressing the security issues involved?

@anmonteiro: are there any outstanding PRs you want to get in?

I just merged the last 3 I saw from you

@dnolen: thanks, those were the ones

k

@dnolen: if you’re looking at Om, it might be a good time for me to say that there are a bunch of issues that I think are no longer valid

or already solved

@anmonteiro: cool, do you have some in mind for me to look at?

@dnolen: these have been solved: https://github.com/omcljs/om/issues/637 https://github.com/omcljs/om/issues/673 https://github.com/omcljs/om/issues/679 https://github.com/omcljs/om/issues/727 https://github.com/omcljs/om/issues/732 https://github.com/omcljs/om/issues/734 these are invalid / questions: https://github.com/omcljs/om/issues/726 https://github.com/omcljs/om/issues/675

thanks! closed all of those

1.0.0-alpha41 is on Clojars

cool stuff!

@dnolen: you forgot https://github.com/omcljs/om/issues/637

oops thanks

🙂

Hi, I'm going through Om basic tutorial (https://github.com/omcljs/om/wiki/Basic-Tutorial), now at "Higher Order Components". I always see only single entry from the dataset, the top one. Is this some known issue? I can't find any difference in what I've written and what's in the tutorial, so could you point me to the right place? I've pasted this code into a Gist: https://gist.github.com/zygm0nt/4f27cb733552f79ccf31257185b95143