nrepl

Daniel Slutsky 2022-02-20T13:44:19.197619Z

Hi @bozhidar@pez. Just noticed a little gap between CIDER and Calva. If we have the following code:

^:abcd [1]
(that is, a vector with a number in it, with some metadata before it), and we put the cursor after this piece of code, then cider-eval-last-sexp would pass the code ^:abcd [1] to nREPL, while Calva: Evaluate Current Form would pass only [1]. I'm wondering what might be better (I tend to prefer the CIDER behaviour here, since we sometimes use metadata in interactive visualization tools).

pez 2022-02-20T13:54:47.069109Z

I think metadata should be considered as part of the form and evaluated together. Please file an issue on Calva about this.

👍 2
🙏 1
pez 2022-03-01T18:05:05.959649Z

This was quite tricky to fix! In the end it is mostly some long overdue clean-ups of rats nests in the code, so I am quite happy I put in the work. 😃 https://clojurians.slack.com/archives/CBE668G4R/p1646157715170719

❤️ 1
Daniel Slutsky 2022-02-20T14:13:05.756539Z

Here: https://github.com/BetterThanTomorrow/calva/issues/1551 Thank you so much.

🙏 1