clojure-lsp --version

Check the https://clojure-lsp.io/troubleshooting/#server-log to make sure JDK was installed properly, more info https://clojure-lsp.io/settings/#java-support

I get this:

$ bash <(curl -s ) --dir ~/Dropbox/bin
Downloading  to /var/folders/2m/h3cvrr1x4296p315vbk7m32c0000gp/T/tmp.F7hhsRuJ
Moving /Users/borkdude/Dropbox/bin/clojure-lsp to /Users/borkdude/Dropbox/bin/clojure-lsp.old
$ clojure-lsp --version
clojure-lsp 2022.03.31-14.21.14
clj-kondo 2022.03.10-SNAPSHOT

Hmm, no binary found on path - assuming clojure-lsp --version should be called from a standard shell - maybe the Emacs installed one does some fiddling with paths to install an emacs visible only one? I guess I can try doing the bash install and set lsp-clojure-custom-server-command ?

I suggest you follow the installation instructions https://clojure-lsp.io/installation/

if you installed via emacs with lsp-install-server, you can try lsp-clojure-server-info to get the info if clojure-lsp is already running in that project

Thanks - I added the cli install and see the 3.31 version, much appreciated 😄

is there any emacs-side settings required to enable the java support? I see a note in the release about a :java key - not sure if that belongs in a clojure-lsp rc file or something? or in emacs

@UKFSJSM38 Thread/sleep also doesn't navigate to anything for me btw, have you implemented that Java source download?

or should I set JAVA_HOME somewhere?

yes, behind a disabled flag as mentioned https://clojure-lsp.io/settings/#java-support

but if you have JRE with src.zip on it it should work without downloading anything

I'm pretty sure java is on my PATH but no nav

Check what is printed on server logs

please specify server logs

https://clojurians.slack.com/archives/CPABC1H61/p1648747391662639?thread_ts=1648747235.367279&cid=CPABC1H61

[1;31mjava.nio.file.NoSuchFileException[m: [3m/private/tmp/project/https:/raw.githubusercontent.com/clojure-lsp/jdk-source/main/openjdk-19/reduced/source.zip[m

That looks like a problem

yeah, sounds like a corner case

what is in your JAVA_HOME ?

also I did not configure lsp to download it - you said it defaults to not downloading - so why is that appearing in the logs? ;)

I haven't set JAVA_HOME

could try that first

another minor point, why didn't you use XDG_CACHE instead of XDG_CONFIG for this cached file?

not sure, We already have XDG_CONFIG use for other configs, I thought it would be a good place

but XDG_CACHE sounds better

anyway, it should not say it's downloading unless you have :java :download-jdk-source? set

Can I specify the path to src.zip?

yes, via :java :jdk-source-uri

ok

but you do you mind help find what issue is that ? 😅

other users may have the same

which issue?

https://clojurians.slack.com/archives/CPABC1H61/p1648747906421319?thread_ts=1648747235.367279&cid=CPABC1H61

I want to understand why that happened

could you paste the server logs? after server starts, there should be logs with [JAVA] tag

well, it seems it tries to download from github right? but it appends my file system path before the url :)

but do you have :java :download-jdk-source? enabled so?

no

that's why I found it surprising that I saw that. I haven't changed anything to my config

Oh, I think I found the issue

yeah, a recent commit introduced a bug

One more reason I didn't want to release that soon 😂

:)

I'm sure there is a good workaround for this

specifying the URI on the setting should do the tricky, but without that it probably will fail :/

You can document that workaround and change the docs on the next release maybe?

@UKFSJSM38 ^

I don't get it, what is the issue?

When I go to def of a dependency, I'm getting the wrong uri scheme back. I expect zipfile://... but get jar:file://...

hum, got it

it's related with the java change

will work on that fix and make a hotfix @U0BUV7XSA

thanks

the external-analysis and project-analysis test in queries_test.clj looks like they aren't actually testing dependency-scheme The code and docs are also pretty confused between whether it should be zip or zipfile (i think it just checks = "jar" so this is less urgent but was confusing to troubleshoot)

@U0BUV7XSA just to make sure, this happens when you find a definition of a external clojure/java file?

haven't tried java, but clojure yes, like medley

👍

go to def on medley/map-vals

@U0BUV7XSA I'll send the fix, but I think java analysis won't work for zipfile users (only vim?) for now 😔 We should think later how to fix that

thanks. yeah, I think only the decompiled would be insurmountable

Could you please test master again?

LMK if you have any suggestion regarding the insurmountable decompiled for zipfiles

well I guess you could write to a tempfile and send a uri there

or just say that to use it you need to use that content call

yeah, good point, will think a little more about that, meanwhile I'll release the hotfix and leave that for next release which I don't want to delay that much

LMK if master fixed the issue so I can hot-release

@UKFSJSM38 master is fixed

thanks!

thank you!

I guess, for my own workflow. Needing to read java (compared to clojure) sources is very rare. But, method completion and hover (with docs) will be sublime. So I'm not too concerned with zipfile compatibility there.

yeah, agreed, but I'll try to fix that, vim users use zipfile right? so more people may want to have java support just like other editors

yeah, I see that jdk sources are in .lsp/.cache and that works fine

what works fine? are you able to go to definition of that java class definition or you manually opened it from cache?

Yeah I can go to def of clojure.string then go to def of java.util.regex Pattern

hahahah 🤯

hahahahahaha!!!! 👿

just jdk sources are found tho.

in contrast to what other sources?

Oh I know what's happening

it will find everything that has source .java

so java.* packages work, cause it's redirecting me to the .cache. but like com.cognitect.* doens't

decompile won't work because it pass to that function

@U0BUV7XSA try some lsp4j classes that also has source code

yup, those do work

like InitializeParams

yeah, ok so I had tried transit and it didn't work

alright, now things make sense 😂

as an aside, I don't have problem to go to a clojure dep

Going to try master

Ah, now that doesn't work for me anymore

java.net.MalformedURLException: unknown protocol: zipfile

so, release works, master no more.

what code did you try to find definition?

a java class

a clojure lib is okay

that won't work for .class yet

for vim users 😔

On the relese version it works

that's odd, it should work only if the java source is available

@U0BUV7XSA I was wondering, would work make vim always use "jar" dependency-scheme? so all clients follow same rules

Nope, it definitely decompiled the class and showed me the decompiled source

quite weird

anyway, I intend to investigate that tomorrow or by the weekend, making it work for zipfile too

okaydokey.

On the released version, I remove the .lsp/.cache directory, open up a file containing a java jar, goto definition and it gets decompiled and opens up for me on vim

on master, same process, but [Server] java.net.MalformedURLException: unknown protocol: zipfile

I'm using the default dependency scheme of zip (as I haven't set it explicitly)

Let me know if I can be of any further help/testing.

Released the fix, I'll work on zipfile fixes on weekend

As mentioned https://clojure-lsp.io/settings/#java-support, it tells to clojure-lsp to download the source of JDK if not found locally

sorry, I meant "what does this mean for the format in the config"

I don't understand how two keywords in a row translates into a setting in the config

oh, sorry

I didn't ask very well 😬

{:java {:download-jdk-source? true}}

ok, cool

that was my guess after thinking on it for a minute or two

thanks!

writing the full map would make docs a little bit bigger, but maybe clearer?

dunno

it would certainly make it a lot clearer

I do wish it was more common to have a list of all the possible options with links out to their documentation

I realize that's a lot of work, though

there is: https://clojure-lsp.io/settings/#all-settings > https://github.com/clojure-lsp/clojure-lsp/blob/master/docs/all-available-settings.edn

ohhhhh

maybe we should highlight a littel better that

well then

😅

should those all be keywords and not symbols?

yep

just like that edn file

and having 2+ on a line for name means they're nested

yes

oh nice, it links to an edn file too

thanks for your patience here, eric

np!

suggestions are welcome

I wonder if there's a better way to convey nesting. I'll have to think about that

Does all-available-settings.edn translate into something? Like, a ~/.config/clojure-lsp.edn ? Or a per-project file? (if so, what name? Just put in deps.edn?)

well, I did something about the things I knew were pretty simple fixes https://github.com/clojure-lsp/clojure-lsp/pull/898

@U96DD8U80 https://clojure-lsp.io/settings/#global

there are a couple global locations you can put a global config for clojure-lsp

and, obviously, for individual projects as well but those are the global ones

hmm maybe something like:

`:java`>`:download-jdk-source?

or an eql query?

{:java :download-jdk-source?}

no, that's more confusing

yeah I think it's more confusing

well, it's clojure-lsp, we could be cute about it

change the column name from "name" to "get-in" and use the get-in syntax for the nested values

@U02N27RK69K we don't add : to settings on that docs because it's possible to pass docs via initializationOptions as json :/

oh

well, :clean already had that

whoops

yeah, we need a better naming converntion for nested configs

I can think of some ways to do this that are interesting

a toggle for showing json vs edn, using "jq" as the header for json and "get-in" for edn

or just a column for each

¯\(ツ)/¯

I'll close my PR

yeah, maybe we should improve that table somehow

it's the consistency (or inconsistency) that confuses me

the docs throughout generally use keywords and edn, but not in the table (except for :clean)

yeah, so let's go with the : , which is way most common

does an option like :download-jdk-source? translate to "download-jdk-source?" in json?

yes

but I think using the json it's pretty uncommon nowadays with clojure-lsp file config

should I re-open my PR then?

oh, you re-opened already 🙂

I'll bet I can make it a toggle at some point here, purely in js

that'd be awesome

but maybe it would make the markdown a little bit worst to maintain?

oh, no, I'd have the js translate the edn to json

maybe not, as it'd be a separated js

yep

sounds like a good improvement

although I'm not sure how you'd handle `

#re ".*"

or symbols

yeah, there is a pretty chance that they don't work at all or we cast it wrongly 😅

initializationOptions are json settings that usually editors send, so they use just one or two settings, nothing advanced

example: https://github.com/emacs-lsp/lsp-mode/blob/master/clients/lsp-clojure.el#L397-L398

I see

maybe it pays to just have the json listed in that column for those specific values

as a way of saying "these are supported in json"

yeah, I think we should support all as json, so I'm okay adding a note somewhere, maybe on initializationOptions section saying that a json is expected and ifsomething not works, fix on clojure-lsp

I think a lot of this could be replaced by merging in ~/.lsp/config.edn(which I think we do now?) or ~/.lsp/profile.edn Then dropping support for config coming from initializationOptions since it really does confuse things. The way I thought about initializationOptions are for global or user specific settings whereas project/.lsp/config.edn are shared, project specific.

Not sure, dependency-scheme is required since all emacs users should send jar, same for Calva

So we need a Editor way to set a config

ah 😕

That's my point regarding of that setting, would be possible make vim (the only editor that uses zipfile AFAIK) to use jar as well?

there's some nice benefits to it, for clojure files you can actually edit within zipfile after jumping in.

Hum, but do we need that? you should not edit a external deps right?

Sounds like a really corner case

Don't use it often, but when it's needed to debug something within it's really really nice.

Like service startup problems before repl is accessible.

Obviously I forgot the def symbol too

Só the CPU came from emacs and not clojure-lsp?

It could be lsp-mode or even other emacs packages

yes

I had to forcequit my emacs

The emacs profiler is the best tool to understand that

Or for that case: toggle-debug-on-quit

Which would stop emacs and tell what was doing and the stack

I could not type anything anymore

so how I can turn something on if I cannot type?

Yeah, that would be needed to be turned before the freeze :/

well I can repro it easy enough

will try tomorow

Mine is not freezing at this case (speaking as a freezing emacs user 🙂 )

it could be flycheck invoking clj-kondo over and over, but I didn't see the clj-kondo process at all

I occasionally have random freezes of emacs too. Usually nothing is using much CPU, it just stops responding. But, this is an issue as old as time. https://www.reddit.com/r/emacs/comments/k7cku8/when_emacs_hangs_what_do_you_do/

Still, it's pretty pretty rare to me some emacs hang that hitting C-g multiple times doesn't solve it 😅

Yesterday's freeze wasn't solvable by any means, but I'll try the signal

So I reproduced it again and did pkill USR2

Debugger entered--Lisp error: (quit)
  bounds-of-thing-at-point(sexp)
  clojure-match-next-def()
  imenu--generic-function(((nil clojure-match-next-def 0)))
  imenu-default-create-index-function()
  imenu--make-index-alist(t)
  which-function()
  which-func-update-1(#<window 3 on foo.clj>)
  which-func-update()
  apply(which-func-update nil)
  timer-event-handler([t 0 0 500000 t which-func-update nil idle 0])

not sure what that is

clojure-match-next-def this is from clojure-mode right?

Think so?

cider or cljr could be using that

or even just clojure-mode itself

not connected to cider in that buffer

so just clojure-mode , from docs: > Scans the buffer backwards for the next "top-level" definition.

what did you do before that hang?

https://github.com/clojure-emacs/clojure-mode/blob/b7d08b87f6a116ff47b33ee857926b60c66c3ab7/clojure-mode.el#L739

https://clojurians.slack.com/archives/C099W16KZ/p1648845524018029