Fork me on GitHub
#lsp
<
2021-04-07
>
ericdallo17:04:44

clojure-lsp Released https://github.com/clojure-lsp/clojure-lsp/releases/tag/2021.04.07-16.34.10: • Fix renaming keywords in cljc files producing duplicate edits. @rvlo • After project startup, publish all project only diagnostics to client. This is a approach done by other LSPs to make work features like https://emacs-lsp.github.io/lsp-mode/page/main-features/#project-errors-on-modeline. Feature flag via lint-project-files-after-startup? with default true. • Add experimental support for aarch64 linux native binary (the CI pipeline did't work yet, need to investigate @brandon.ringe ) • Fix formatting issues with a regression introduced on a previous release. - Fixes https://github.com/clojure-lsp/clojure-lsp/issues/399 and https://github.com/clojure-lsp/clojure-lsp/issues/396 c/c @nicdaoraf Any issues with wrong LSP formatting/indentation, this release should fix it

🎉 4
👍 2
jcsims21:04:59

I noticed what looks like a bug here: https://github.com/emacs-lsp/lsp-mode/blob/master/clients/lsp-clojure.el#L217-L218, where concat is used instead of e.g. f-join. This results in a missing path separator for the second item in the list (where lsp-workspace-root returns a path without a trailing slash), and the result is a path something like "/Users/jcsims/code/kondo-test.clj-kondo/config.edn" instead of "/Users/jcsims/code/kondo-test/.clj-kondo/config.edn"

ericdallo22:04:07

yes, you are right 🙂

ericdallo22:04:19

feel free to open an PR on lsp-mode!

👍 1
jcsims21:04:18

I think f-join is the right thing there - ok if I open a PR to that affect?