Does it have a way to provide a cookie?

Yes, it has, but in a very roundabout way... I'll go with dependencies 😃

What does node-fetch offer for cookies that Node's http and https libs don't do? It's just one of the headers.

In fact looking at the docs for node-fetch, looks like it makes dealing with cookies harder, by not saving cookies by default, and requiring you to use a separate "raw" response to read them.

Answering your question directly, "Does it have a way to provide a cookie?": I haven't done that recently, but if memory serves, you should be able to just include a headers object in the options map. So in JS, with get already promisified, that would look like:

get(url, {headers: {'Cookie': 'myCookie=myvalue'}})
  .then(handle-response)

in util_aoc.cljs, this ns form:

(ns util-aoc
  (:require ["vscode" :as vscode]
            ["requestify" :as fetch]
            [clojure.edn :as edn]
            [promesa.core :as p]
            [clojure.string :as string]))

In aoc2022_1.cljs this content:

(ns aoc2022-1
  (:require [util-aoc :as aoc]))

(def input (aoc/values+ 1))

Now starting from a fresh REPL, I load aoc2022_1.cljs, and get:

; Evaluating file: aoc2022_1.cljs
; Cannot find module 'requestify'
; Require stack:
; - /Users/pez/Recordings/util_aoc.cljs
; Evaluation of file aoc2022_1.cljs failed: #error {:message "Cannot find module 'requestify'\nRequire stack:\n- /Users/pez/Recordings/util_aoc.cljs", :data {:type :sci/error, :line 2, :column 3, :message "Cannot find module 'requestify'\nRequire stack:\n- /Users/pez/Recordings/util_aoc.cljs", :sci.impl/callstack #object[cljs.core.Volatile {:val ({:line 2, :column 3, :file "/Users/pez/Projects/joyride-aoc/.joyride/scripts/aoc2022_1.cljs", :ns #object[T1 aoc2022-1]} {:line 2, :column 3, :file "util_aoc.cljs", :ns #object[T1 util-aoc]})}], :file "util_aoc.cljs"}, :cause #object[Error Error: Cannot find module 'requestify'

I can load util_aoc.cljs and use requestify just fine.

dunno, if you can make a issue repro, I can take a look sometime soon, but you could also try debugging the :load-fn yourself where it loads the npm libs. could be an issue with resolving in the wrong directory or so

This would be in Joyride or can a Joyride script do it?

you can script this

I get errors:

; Evaluating file: util_aoc.cljs
; Could not resolve symbol: clojure.core/unquote-splicing
; Evaluation of file util_aoc.cljs failed: #error {:message "Could not resolve symbol: clojure.core/unquote-splicing", :data {:type :sci/error, :line 10, :column 14, :message "Could not resolve symbol: clojure.core/unquote-splicing", :sci.impl/callstack #object[cljs.core.Volatile {:val ({:line 9, :column 1, :ns #object[T1 util-aoc], :file "/Users/pez/Projects/joyride-aoc/.joyride/scripts/util_aoc.cljs"} {:line 10, :column 3, :ns #object[T1 util-aoc], :file "/Users/pez/Projects/joyride-aoc/.joyride/scripts/util_aoc.cljs"} {:line 10, :column 10, :ns #object[T1 util-aoc], :file "/Users/pez/Projects/joyride-aoc/.joyride/scripts/util_aoc.cljs"} {:line 10, :column 14, :ns #object[T1 util-aoc], :file "/Users/pez/Projects/joyride-aoc/.joyride/scripts/util_aoc.cljs"})}], :file "/Users/pez/Projects/joyride-aoc/.joyride/scripts/util_aoc.cljs", :phase "analysis"}, :cause #error {:message "Could not resolve symbol: clojure.core/unquote-splicing", :data {:type :sci/error, :line nil, :column nil, :file "/Users/pez/Projects/joyride-aoc/.joyride/scripts/util_aoc.cljs", :phase "analysis"}}}

you need a syntax quote before (.then

(edited my original post)

🚀

tested it in nbb:

user=> (defp x (p/delay 1000 :hello))
#<Promise[~]>
user=> x
:hello 

😴

Sleep tight!

(ns aoc2022-1
  (:require [promesa.core :as p]
            [util-aoc :as aoc]))

;; Unwrapping the a promise is a bit involved...
;; Read this as something like:
#_(await-def real-input (aoc/values+ 1))
(.then (aoc/values+ 1) #(def real-input %))

(def test-input [1000
                 2000
                 3000
                 nil
                 4000
                 nil
                 5000
                 6000
                 nil
                 7000
                 8000
                 9000
                 nil
                 10000])

(defn part-1 [input]
  (->> input
       (partition-by nil?)
       (map (partial apply +))
       (apply max)))


(comment
  (part-1 test-input)
  :rcf)

(part-1 real-input)

That is, my solution code can be promise free.

https://github.com/borkdude/advent-of-babashka-template/blob/fe6467dbd8d9548cfa8ab76c5b7b6766548511bf/src/aoc22/day01.cljc#L12

same over there

but in node you can also use readFileSync

Haha, so similar to mine!

(def fetch-input+
  (memoize fetch-input'+))

(defn values+ [day]
  (p/let [values (fetch-input+ day)]
    (->> values
         (string/split-lines)
         (map edn/read-string))))

I should make my slurp take a Url too of course...

(defn slurp+ [ws-path]
  (->
   (p/let [ws-root (-> vscode/workspace.workspaceFolders first .-uri)
           uri (vscode/Uri.joinPath ws-root ws-path)
           data (vscode/workspace.fs.readFile uri)
           text (.decode (js/TextDecoder. "utf-8") data)]
     text)
   (p/catch (fn [e]
              (println "Ho, ho, ho! Path not found:" ws-path e)
              (throw (js/Error. e))))))

(defn- fetch-input'+ [day]
  (->
    (p/let [cookie (slurp+ ".aoc-session")
            response (.get requestify
                           (str "" day "/input")
                           #js {:cookies #js {:session cookie}})]
      (.getBody response))
    (p/catch (fn [e]
               (println "Ho, ho, ho! Did you forget to populate `.aoc-session` with your AOC session cookie?" e)
               (throw (js/Error. e))))))

(def fetch-input+
  (memoize fetch-input'+))

(defn values+ [day]
  (p/let [values (fetch-input+ day)]
    (->> values
         (string/split-lines)
         (map edn/read-string))))

yeah, you can download those inputs separately from running your solution

and then your solution becomes sync

I sort of do it separately, with that memoize.

And the await-def you handed me works just fine for making it sync in my solution code.

it's not sync, the def is still being defined at a point in the future, but for REPL purposes it works

It works when I run the script as well. But that's in the REPL too, right?

What I mean is that my solution code will look exactly the same whether the input is defined now or at a point in the future.

well, as long as the input is there before the puzzle runs...

which might not be the case the first time

I see....

I'll solve that with some instructions.

Or, maybe I should allow my solutions to be async instead... Hmmm...

Then await-def is a bad name for this, right?

Regarding the original concern of how to "unwrap" a promise, I would favor simply peeking inside.

(defn tap [x] (tap> x) x)

(-> my-promise
  (p/then tap)
  (p/then whatever-i-was-doing-with-result))

yeah, I think that's better

We don't have tap> in Joyride, have we?

hmm. That's unfortunate.

prn to the rescue, I guess...

we can add tap> of course

just add it to the config in joyride.sci

💤

goodnight

Issue please, @U90R0EPHA. And PR too, if you like. 😃

https://github.com/BetterThanTomorrow/joyride/issues/112 My best interpretation of the SCI docs and existing code is that I should be able to add it to the map after`'clojure.core` at https://github.com/BetterThanTomorrow/joyride/blob/8de67c5eb6eec93767fcd9df05a710ce5d274da6/src/joyride/sci.cljs#L78.

; formatted to far-left for readability in Slack

:namespaces
{'clojure.core
 {'IFn (sci/copy-var IFn core-namespace)
  'tap> (sci/copy tap> core-namespace)
  'add-tap (sci/copy-var add-tap core-namespace)
  'remove-tap (sci/copy-var remove-tap core-namespace)}

This stuff is not hot-reloaded. Just saying that, I don't think you actually assumed it was, or that this is the issue.

> My best interpretation of the SCI docs and existing code is that I should be able to add it to the map after`'clojure.core` at https://github.com/BetterThanTomorrow/joyride/blob/8de67c5eb6eec93767fcd9df05a710ce5d274da6/src/joyride/sci.cljs#L78. Correct

> This stuff is not hot-reloaded. Oh yes. I forgot to build before testing. :face_palm: So all the relevant symbols exist now. But I am not really sure how to try setting a print target with bound-fn* not available.

=> (add-tap prn)
nil
=> (tap> :foo)
true
; no print output

Side note: once tap> is working, my suggestion of an explicitly defined tap function could be optionally replaced by an inline #(doto % tap>).

My rule of thumb is to not add things to clojure.core in SCI that are not in clojure core.

Is that in reference to`bound-fn*`? That is in Clojure core (https://github.com/clojure/clojure/blob/5ffe3833508495ca7c635d47ad7a1c8b820eab76/src/clj/clojure/core.clj#L2030*), though seems to be missing in ClojureScript. There is a mk-bound-fn added to Cljs (https://github.com/clojure/clojurescript/blob/e7cdc70d0371a26e07e394ea9cd72d5c43e5e363/src/main/cljs/cljs/core.cljs#L9742-L9746), which I guess is likely intended as a replacement. It takes 3 arguments though. I'm not sure how that translates. Honestly I have zero understanding why it is even needed. All I know is I can get a basic tap-to-print working in clj project by wrapping whatever print-fn in bound-fn*. If I don't, then it doesn't work there either. Rather than requesting to add more stuff to SCI, I think I was more hoping for guidance from an expert on how this should work without bound-fn*.

I have no clue what you are even doing to be honest. Can you state a problem statement as if I'm a complete noob?

The primary goal at the moment is just to verify that tap> is working correctly in Joyride, so I can submit a PR for it. Because the easiest way to test this seemed to be printing a tap, that led to a separate goal, which is: I want to be able to use tap> in my code, and have that output to a built-in print function, such as prn, even if I am not running on JVM Clojure.

The reference for joyride is CLJS, not the JVM. So if you have a working example in CLJS (or nbb), we can make that the same in joyride

in nbb:

user=> (add-tap prn)
nil
user=> (tap> 1)
true
user=> 1

https://github.com/babashka/nbb/blob/79bc68474afa9d79bb037613b36b1ce20b3acb4d/src/nbb/core.cljs#L542-L544

:thinking_face: That is exactly what I have added to Joyride, but does not seem to work, neither in Joyride REPL ...

user=> (add-tap prn)
nil
user=> (tap> 1)
true
user=> 

=> nil

=> true

can you try a different tap function? it might be something weird with the print-fn

e.g. the vscode information message thing

(v/window.showInformationMessage "foo")
;; foo

(add-tap v/window.showInformationMessage)
(tap> "foo")
;; nothing

(add-tap #(v/window.showInformationMessage %))
(tap> "foo")
;; nothing

I think it's best to file a PR, and get feedback on that one. Draft it, if you think that's appropriate.

The issue is not in the printing.

(def n (atom 0))
(add-tap #(swap! n + %))
(tap> 5)
@n       ; => 0

https://github.com/BetterThanTomorrow/joyride/pull/113