@U0ZCYC77T Can you explain what problem you are trying to solve? Or is this just a preference in terms of the generated SQL?

@U04V70XH6 Here's the specific problem I'm running into:

; I want this quoting behavior, but with :sqlserver quotes
(sql/format {:select [:some##field :another-field]})
;; => ["SELECT \"some##field\", another_field"]
;; 
;; passing a dialect quotes everything
(sql/format {:select [:some##field :another-field]} {:dialect :sqlserver})
;; => ["SELECT [some##field], [another-field]"]
;; 
;; turning quoting off passes the first field unquoted
(sql/format {:select [:some##field :another-field]} {:dialect :sqlserver :quoted false})
;; => ["SELECT some##field, another_field"]

Right, but what problem are you trying to solve? Quoting all the fields is not a problem in itself.

That's why I asked if this is just preference on your part?

You can set the (default) dialect globally -- is that what you're asking about?

https://cljdoc.org/d/com.github.seancorfield/honeysql/2.4.980/api/honey.sql#set-dialect!

Was that the answer? You wanted the default dialect to be SQL Server, rather than ANSI?

Oh, sorry. I'm migrating a codebase from HoneySQL 1 -> 2, was just trying to match the existing behavior. I'm actually not sure if quoting everything will cause a problem in our case, I'll try that.

And, I just figured out what I needed:

(sql/format {:select [:some##field :another-field]} {:dialect :sqlserver})
;; => ["SELECT [some##field], [another-field]"]
;;
(sql/format {:select [:some##field :another-field]} {:dialect :sqlserver :quoted nil})
;; => ["SELECT [some##field], another_field"]

:quoted nil restores the default quoting strategy (only quoting unusual entity names) Many thanks @U04V70XH6

You have multiple DB dialects in play? Else you could just set one as the global default:

user=> (require '[honey.sql :as h])
nil
user=> (h/set-dialect! :sqlserver)
nil
user=> (h/format {:select [:some##field :another-field]})
["SELECT [some##field], another_field"]
user=>

We do, we're using honey.sql in a data warehouse coordinator system

ETL from a bunch of source DBs

Thanks again!

I'll create an issue to review the docs around the :dialect option and make sure it's clear that you can explicitly use the "default quoting" via :quoted nil

I'm happy to work on that

https://github.com/seancorfield/honeysql/issues/463

If you want to send a PR for it, that would be great since I may not get to it for a few weeks.

Will be happy to.