Fork me on GitHub
#helix
<
2021-03-11
>
Jimmy Miller20:03:29

So it looks like use-subscription is a little broken. When I try to use it, even with the test example in the source, it infinite loops. After some debugging, it looks like the react/useEffect doesn’t have the thunk around it. https://github.com/lilactown/helix/blob/f1c211f67785ee2a71a78db76f1b29060145c386/src/helix/hooks.cljc#L340-L341 Pulling that into my project and adding the thunk makes everything work. Happy to make a PR just wanted to write here to make sure I wasn’t missing something.

lilactown21:03:40

yes a PR would be appreciated!