Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2021-10-11

Channels

#fulcro
<
2021-10-11
>
henrik10:10:43

Hi @tony.kay! It seems like there's a problem https://github.com/fulcrologic/guardrails/blob/89eca32ddb0e3d1594c67c862c8bfffe6dbce7c2/src/main/com/fulcrologic/guardrails/impl/externs.cljc#L123, where shadow-cljs doesn't like IllegalArgumentException., since it's not available in CLJS.

tony.kay15:10:29

thanks…fixing and will release in a moment

tony.kay15:10:34

fixed

👍 1
hadils21:10:12

Hi @tony.kay. I enabled guardrails in my REPL and it caused these calls to fail: ` 

(datetime/set-timezone! "America/Phoenix")

tony.kay21:10:04

yeah, I should probably just change that to string?

tony.kay21:10:16

the side-effecting into a spec is a bad plan IMO

tony.kay21:10:50

I think I originally thought that was some internal definition, but it seems like in some cases it has to be loaded or something

tony.kay21:10:20

See 1.0.26 on clojars (released just now)

tony.kay21:10:28

thanks for reporting the problem

tony.kay23:10:51

YEah…not sure why you were getting an empty set…probably a package.json problem if cljs so that the zone ids were not loading…so you probably still have a problem, but I’m fine with the spec not causing a compile error in this case.

hadils21:10:25

I have pinpointed the problem to the definition of ::zone-id in the com.fulcrologic.rad.type-support.date-time namespace. The set defining it is empty.