Fork me on GitHub
#editors
<
2018-05-13
>
andresrgz09:05:04

Hello @pez and @pedrorgirardi! I hope you guys are doing fine and having a great weekend. I just added a feature to Calva, please check it out and tell me what you think. πŸ™‚ https://github.com/BetterThanTomorrow/calva/pull/39

pez09:05:58

@andres.rodriguezhn: Many thanks for helping out! I’m having a look.

pez09:05:31

Looks good and things still work. πŸ˜ƒ. I pulled it in. Again, thanks! FYI we are probably going to continue/restart the porting to ClojureScript in a separate branch and mainly do bug fixes on the current hybrid Javascript/Clojurescript version, but this change makes sense to add anyway, since it broadens the application of Calva (and will rebase cleanly onto the β€œrewrite” branch).

andresrgz09:05:12

Cool! On what OS did you try it?

andresrgz09:05:59

Thanks for accepting this feature, I'm a college student and this is my first pull request for an open source project! πŸ™‚

pez09:05:48

Mac. But from the look of things the defaults make things that used to work, keep working w/o the users having to change anything, regardless of OS.

andresrgz09:05:14

Nice, that's what I was aiming for haha.

pez09:05:09

Cool that Calva got your first PR ever! πŸ˜ƒ

pedrorgirardi11:05:29

Thank you @andres.rodriguezhn !! πŸ˜ƒπŸ˜ƒπŸ˜ƒ