Clojurians Log v2
Clojure programming
Channels
Apps
editors 2018-05-13
andresrgz 2018-05-13T08:03:35.000028Z
@andres.rodriguezhn has joined the channel
andresrgz 2018-05-13T09:20:04.000054Z
Hello @pez and @pedrorgirardi! I hope you guys are doing fine and having a great weekend. I just added a feature to Calva, please check it out and tell me what you think. 🙂 https://github.com/BetterThanTomorrow/calva/pull/39
@andres.rodriguezhn: Many thanks for helping out! I’m having a look.
andresrgz 2018-05-13T09:26:09.000042Z
No problem!
Looks good and things still work. 😃. I pulled it in. Again, thanks! FYI we are probably going to continue/restart the porting to ClojureScript in a separate branch and mainly do bug fixes on the current hybrid Javascript/Clojurescript version, but this change makes sense to add anyway, since it broadens the application of Calva (and will rebase cleanly onto the “rewrite” branch).
andresrgz 2018-05-13T09:38:12.000027Z
Cool! On what OS did you try it?
andresrgz 2018-05-13T09:38:59.000060Z
Thanks for accepting this feature, I'm a college student and this is my first pull request for an open source project! 🙂
Mac. But from the look of things the defaults make things that used to work, keep working w/o the users having to change anything, regardless of OS.
andresrgz 2018-05-13T09:40:14.000086Z
Nice, that's what I was aiming for haha.
Cool that Calva got your first PR ever! 😃
pedrorgirardi 2018-05-13T11:02:29.000107Z
Thank you @andres.rodriguezhn !! 😃😃😃
jeremy 2018-05-13T04:51:18.000027Z
@jeremy642 has joined the channel