Clojurians Log v2

so far I got around by forking component and adding my measurement code there, but would be nice a way that doesn't require hacking the library

What do you mean by start?

how long the start fn (from Component/start) takes to run, for each component

this is what I did on my hack:

(defn- try-action [component system key f args]
  (try (println "starting" component)
       (time
         (apply f component args))
       (catch #?(:clj Throwable :cljs :default) t
         (throw (ex-info (str "Error in component " key
                           " in system " (platform/type-name system)
                           " calling " f)
                  {:reason     ::component-function-threw-exception
                   :function   f
                   :system-key key
                   :component  component
                   :system     system}
                  t)))))

(the hack is back because this fn might be called during stop as well, but just a dirty hack to get it working for my case)

Sure, but I mean, take a step back, of your application is slow to start it is very unlikely that component start time meaningfully contributes to that

it actually is, from my debug I could find a single component taking 97s to start

from the 120s total

That is crazy

It is possible to do arbitrary stuff in start, but that doesn't mean you should

well, the slow ones are things that depend on external data, so they have to download things from the internet, it happens the perpetrator is doing a lot of downloading

Oof, horrendous

so, this debug allowed me to pinpoint that component, and that's the gist of why I want something like that

Sure, well the component library has a function I forget the name of that basically maps whatever over the components in a system

Starting a system is using that function together with the start function

So you just use that function with a function that wraps start with time

(update-system s (keys s) (fn [c] (prn (type c)) (time (start c)))) or something

But once you identify the components that are fetching things over the internet when starting, absolutely ditch them

its not that easy, because the components might implement other protocols other than the component one (and most on them in my case does) so wrapping that instance while forwarding every protocol is complicated

I think the ideal situation would be have sort of plugins/hooks support on component itself, so we could react to things like start/stop

There is no wrapping

You just use your own call using update-system like above in place of calling start on the whole system

Er start-system

Your can see it is what start-system does https://github.com/stuartsierra/component/blob/master/src/com/stuartsierra/component.cljc#L165 but just adding a call to time

generically

ah, makes sense, afk now, but will try whenI get back :)

ok, this works:

(defn start-measured [component]
  (println "starting" component)
  (time (component/start component)))

(comment
  (time
    (let [sys (system-config)]
      (component/update-system sys (keys sys) #'start-measured))))