generally, I prefer keeping different JVMs for UI and backend to avoid instances like this, as the dev tooling for CLJS can end up clobbering things like that

argh, I didn’t even think of that. Have now ended up with dev-time 2 JVMs anyway so maybe it’s fine, but that’ll get me closer to a good bug report.

hm, wonder if org.mortbay.jetty (xgboost) versus org.eclipse.jetty (figwheel) accounts for this … I could get figwheel to compile but the browser hot-reload websocket couldn’t connect.

I've written some Closure JS code. what's the proper way to bring it into my app?

currently I've just pasted the code into a file on my classpath. is that enough, or do I need to add a foreign-libs declaration as well?

The page at https://clojurescript.org/reference/dependencies has broken markup at the bottom. Not sure what's a better way to notify someone about it.

Thanks, we will fix it up. FYI, the site docs are at https://github.com/clojure/clojurescript-site

Issues and prs are good places to report

Should i be able to bundle es6 modules using :npm-deps? When trying to run the build, I'm getting SyntaxError: Unexpected token 'export'

@danielstockton it's not clear what you mean

"bundle es6" what does that mean?

:npm-deps probably doesn't do what you imagine - it's just used to install Node dependencies

nothing else

Right ok, this is browser side. I wanted to require an npm library into one of my namespaces

if it's present it does mean the compiler with other configuration will index node_modues

have you read the new webpack guide?

https://clojurescript.org/guides/webpack

Nope, will do, thanks

this is the recommended way now - trying to push a node_module through Closure is very challenging or sometimes impossible (and challenging to figure out if it is actually impossible)

@dnolen if I have a Closure JS file in disk that I want to require, do I need to write a foreign lib entry for it?

not if you respect the classpath

so if the naming convention matches the classpath it should just work

I'm trying to load my Closure JS file in a node repl. not working yet

it uses goog.module and goog.module.declareLegacyNamespace();

goog.module('lilactown.harmony');
goog.module.declareLegacyNamespace();

after requiring it, I cannot reference any exports

cljs.user> (require 'lilactown.harmony)
nil
cljs.user> lilactown.harmony
Execution error (ReferenceError) at (<cljs repl>:1).
lilactown is not defined

cljs.user> lilactown.harmony/ref
Execution error (ReferenceError) at (<cljs repl>:1).
lilactown is not defined

@dnolen any ideas?

repo is here: https://github.com/Lokeh/melody/tree/vanilla

Is there any other documentation for core.async 's <p! macro? This is all I've found https://clojurescript.org/guides/promise-interop#using-promises-with-core-async

is there a specific question you have about it? AFAICT the docstring describes it succinctly, but maybe you’re seeing something that’s missing?

Well I honestly couldn't find it in the codebase, but I haven't (doc <p!) yet either

I found it here: https://github.com/clojure/core.async/blob/master/src/main/clojure/cljs/core/async/interop.clj

Thank you 🙏

@lilactown don't use goog.module

use normal goog.provide - goog.module is just a pain

it's possible to handle it but honestly not worth the effort in my opinion

it solves no problems we care about

😕 I'm using code generated by tsickle. I would have to do a lot more rewriting of the Closure JS by hand

I thought goog.provide was deprecated?

for Google

goog.module is a mess

it requires transpilation which is ridiculous

@lilactown I do understand that such a feature would be useful, file a ticket, anybody can work on it

pretty much everything that would need to be done is already there

@lilactown if you interested happy to explain some pointers in #cljs-dev

I would be interested. I might not get to it for a bit though

if tsickle generally gets you Closure modules from TS than of course that's something you'll see in the near future

anyways please write up a ticket and capture the details like this