Hi all, i have ported some JS code example from Google Maps (https://developers.google.com/maps/documentation/javascript/examples/delete-vertex-menu) to ClojureScript (https://gist.github.com/iperdomo/44911ee4ceaafa472338155edc992cbc)

it was largely inspired by some code found in Om source code, but for some reason i didn't manage to get a constructor function that have a div_ property so i workaround it by having a getDiv function

the code works, but i was wondering if there is any improvement one can make do to it to feel more idiomatic

@iperdomo You can just write the initialization inside your ctor function, no? Also, you can use extend-type instead of specify! here.

@rauh i tried to do the initialization, but some how the div DOM element was not accessible afterwards by using (.-div this)

@rauh don't we need protocols to implement or can I reference a JS constructor like js/google.maps.OverlayView ?

@iperdomo Like this:

(let [c (fn [] (this-as this
                 (set! this -div "foo")))]
  (extend-type c Object (get-it [x] (.-div x)))
  (let [i (new c)]
    [(.-div i) (.get-it i)]))

my attempt was ...

i guess because (.-div this) doesn't exist i can't set it, right?

I used #_ to ‘comment’ some code out, but I got a compiler error. Could be reproduced like this: #_::foo/bar, should that break things if foo is not a valid ns?

In JVM Clojure this doesn’t throw

oh, it does…

yes it does

#_ ignores a form after that form has been read

if it’s not readable, it will error

This throws (from the REPL) (+ 1 2 #_::foo/bar 3), but this is accepted: #_::foo/bar

the only comment syntax that prevents reading is ;

@borkdude no, neither works

is the goog/inherits mechanism equivalent to the es6 extends keyword? I’m asking because the rum code base seems to use the former when instantiating a component and I want to make sure I understand what’s going on

@lee.justin.m Pretty much, yeah. extends will still be transpiled by google closure compiler unless you have language-out set to some "new JS". Though, the GCC transpiler uses a few smarter ways to extend the class

(See )

you are assuming I truly understand what extends does 😛

is ctor a common clojureism? I see in in several libraries and in the clojure source

i think in rum and sablono it must mean clojure-to-react

I've seen that used as shorthand for "constructor"

@lee.justin.m @manutter51 It is commonly used as “constructor”. That is true in the Java ecosystem too

If it means clojure-to-react in those libs, that would trip me up 😛

This isn’t definitive, but I took a glance at rums usage of the ctor name and it looks like it means “constructor” there to me.

forehead slap. thanks that should have been obvious.

@rauh thanks for your previous comments, i have updated a working implementation based on extend-type instead of specify! https://gist.github.com/iperdomo/44911ee4ceaafa472338155edc992cbc

works on my machine ™

has anyone run into caching issues with the CLJS compiler and NPM deps? in our project we can't use lein doo without lein clean first because for some reason the CLJS compiler does not include the NPM deps the second time

I'm not sure if this is an actual compiler problem or something to do with our own project. just wanted to see if anyone else had similar issues before I investigate further

the error looks like this (only shows up after a second run):

goog.require could not find: module$Users$rads$src$my_project$node_modules$honeybadger_js$honeybadger

if I copy the files into my project and use :foreign-libs instead the problem goes away