Fork me on GitHub
#clojars
<
2018-01-11
>
martinklepsch18:01:08

I just noticed something weird: the jar for [boot/core "2.7.2"] has a pom.xml with messed up <scm/> section:

<scm>
    <tag>419e07c83dfbcf2e86ed5cf7f26d832fc5e394b5
</tag>
    <url/>
  </scm>

martinklepsch18:01:55

When I checkout 2.7.2 and run cd boot/core/; lein install the resulting jar has the correct pom.xml

martinklepsch18:01:14

Does that make sense to anyone?

danielcompton20:01:30

Clojars rewrites the pom on deploy because of how we do atomic deploys

danielcompton20:01:40

Although I can't remember why it was necessary to rewrite the pom

danielcompton20:01:12

What does the one that you generated look like @martinklepsch?

tcrawley20:01:55

I don't think we rewrite the pom, do we? Only the maven-metadata.xml

tcrawley20:01:59

but I'll double check

martinklepsch20:01:04

<scm>
    <url>https://github.com/boot-clj/boot</url>
    <connection>scm:git:
    <developerConnection>scm:git:
    <tag>419e07c83dfbcf2e86ed5cf7f26d832fc5e394b5</tag>
  </scm>

tcrawley20:01:14

ah, we only rewrite the checksums for maven-metadata.xml I think

tcrawley20:01:23

I don't see anywhere where we would alter the pom at all

martinklepsch20:01:26

Hm. Ok. I don’t want to push anything just to test this but I’ll check next time I cut a release

martinklepsch20:01:30

Thanks for looking into it

martinklepsch20:01:38

lein deploy would not modify pom.xml after it’s been written, would it? 😳

tcrawley20:01:48

what is writing the pom before you call lein deploy? I know lein generates one at some point in the deploy/build process

martinklepsch20:01:44

yeah there’s one in my project root

martinklepsch20:01:56

I checked all poms I could find locally and they all seem correct:

tcrawley20:01:28

Did you generate that one, or did lein?

martinklepsch20:01:34

- pom.xml in project root - .pom file in local ~/.m2 after running lein install - pom.xml in jar file in ~/.m2 after lein install

martinklepsch20:01:39

lein generates the pom