I'm trying to use Google Closure's Html5History to handle navigation within my SPA. This works fine with no optimizations but breaks in advanced mode:

(Html5History. nil
                       ;; Custom TokenTransformer to override the default
                       ;; behavior, which appends the search string to all new
                       ;; tokens.
                       #js {:retrieveToken (fn [prefix location]
                                             (subs (.-pathname location) (count prefix)))
                            :createUrl (fn [token path-prefix location]
                                         (str path-prefix token))})

i.e., I guess I should be passing an instance of TokenTransformer, but instead I just pass a plain object which has the right function names

but it seems the function names get munged by advanced compilation

how do I prevent that? TokenTransformer is defined here, if that helps: https://github.com/google/closure-library/blob/master/closure/goog/history/html5history.js#L311

I'd like to try passing a proper TokenTransformer, but how do I create one in Clojurescript?

Hello @ajpierce . I looked at https://ajpierce.github.io/posts/react-figwheel-npm/ and I tried the steps and got No such namespace: react, could not locate react.cljs, react.cljc, or JavaScript source providing "react". Do you think am I missing something?

for the benefit of anyone having similar problems: the following gist works in advanced compilation: https://gist.github.com/pleasetrythisathome/d1d9b1d74705b6771c20#file-browser-cljs-L14

@aranhoide Read about “externs” for :advanced, which prevents name munging https://clojurescript.org/reference/advanced-compilation

Working on updating my blog post with the new process.env shimming, and I'm noticing that node_modules are no longer automatically installed. Is there a compiler option I need to pass to make that happen?

I've googled a bit but not managed to find any articles on speeding up REPL startup/build time for CLJS projects. Do you guys know of any writeups on the matter or perhaps specific tips? 🙂

@ajpierce :install-deps true for the old behavior and cljs.build.api/install-node-deps! to manually run this step.

@reefersleep :parallel-build helps, but probably the best way is to just partition the build instead of building everything, which may require restructuring the code a bit

cheers @dnolen 🙂 I wonder if there's any partitioning to be done in my hobby projects. All of them are very small to begin with. I'm not very knowledgeable about build processes, as you can tell, which is why I was hoping someone had done a writeup on the theme 🙂

oh for hobby projects speeding up start time isn’t so hard

if you do it right it shouldn’t take much longer than 1.5 seconds on newer hardware

but this is raw REPLs, if you’re going to use Figwheel or nREPL then there’s going to be some startup time

Hah, does a T500 from 2008 constitute "newer hardware"? 😉

But yeah, I'm also using Figwheel

haha no

And since I'm using cider, I guess nREPL too

yeah I’m on a slower machine as well so I’ve done a lot a work around this, but you bottom out at your tooling choices

So I'm really making it hard for myself 🙂

well for example I always use the AOT ClojureScript artifact

just compiling ClojureScript eats into start time

[org.clojure/clojurescript "VERSION" :classifier "aot"]

most tooling however is not AOTed so you have to wait for that stuff to compile

My machine has trouble just running Slack in the browser...

I'l give that and :parrallel-build a go 😄

given your machine and your projects I think :parallel-build will probably not have much impact

a AOTed figwheel-sidecar artifact would probably have much more impact.

ditto for the nREPL bits

I'll look into that, for sure! I must admit that I stopped keeping up with hardware details a long time ago, can't remember when multiple cores became commonplace.

It doesn't seem like AOT builds are available online for figwheel-sidecar. Do I have to clone and compile it myself (possibly with some magic compile flags) to provide it locally?

projects have to make them and publish them

Ach 😕

many projects don’t do this - but I think for critical pieces of the ecosystem I don’t see why people aren’t

AOT can be a bit finicky it’s true but I think ClojureScript shows that it’s possible for a large Clojure project to be AOTed and work as expected

hm, alright. I guess I'll have to lobby @bhauman for AOT of figwheel-sidecar, then 🙂

I'm using reagent and am getting component flashing

I suspect it's because I am using reagent/render more than once

would mounting the same component result in re-rendering even though the data/state is the same?

@dnolen super minor detail but in the readme, maven dependency information still points to <version>1.9.670</version>

after reading around a bit, yep looks like reagent/render would force a re-render

@jpmonettas thanks, fixed

@dnolen As we discussed I creted a minimal repo concerning CLJ-2280 it is linked in the ticket’s comment https://dev.clojure.org/jira/browse/CLJS-2281.

@jeremys this your first time reporting on an issue so I understand you might not be familiar with the process.

In general it’s not acceptable to link outside of the ticket to minimal repro

even less acceptable for the minimal repo to use any form of external tooling

no Maven, no Lein, no Boot

please provide a minimal repo inline in the ticket - demonstrating how to reproduce with only the QuickStart uberjar

glancing over your repo it’s mostly in good shape, just get that info into the issue

also the Node stuff needs to go into a separate issue - assuming these are related is not recommended

Sorry my bad ok I’ll work on that!

I’ll take a look at other tickets to see how to do it properly