Clojurians
#cljs-dev
<
2018-06-24
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

danielcompton23:06:37

@mfikes happy to take over maintenance of the re-frame canary if you'd like?

mfikes23:06:34

@danielcompton Sure. Are you thinking about having re-frame support it directly (in other words, having Canary run its tests)? (via https://github.com/cljs-oss/canary/tree/master#how-to-participate)

danielcompton23:06:45

Yeah I guess so, there's no reason for you to have to sync up with master

mfikes23:06:19

Yeah, if you'd like to do that, just let me know and I'll "shut down" that re-frame clone I made.

mfikes23:06:55

No real need... that was just the first thing I found that works. Feel free to try getting it working in its original mode.

danielcompton23:06:14

Great, also, does this run on every build or just the ones that are triggered by canary?

mfikes23:06:27

@danielcompton If you set re-frame up to run in Travis, it would run in Travis for every re-frame commit, and for every "externally-triggered" Canary test run. Here, for example is the mixture you'd get, using Planck as an exammple: https://travis-ci.org/planck-repl/planck/builds

danielcompton23:06:20

Cool, that's what I expected

mfikes23:06:06

Canary would use the Travis token you set up, so it would perhaps run as Daniel Compton, or perhaps some re-frame specific GitHub account if there is such a thing.

danielcompton23:06:16

nah we don't have anything like that

danielcompton23:06:44

will talk with Mike Thompson to see about merging it in

danielcompton23:06:11

As a side note, it would be nice if the canary stuff could live separately from the actual projects, it's a little bit invasive at the moment

mfikes23:06:49

Cool. I'll add you to cljs-oss so you can commit stuff for re-frame. Yeah, it is a little invasive, I agree. I have no good answer for that.