@mfikes happy to take over maintenance of the re-frame canary if you'd like?

@danielcompton Sure. Are you thinking about having re-frame support it directly (in other words, having Canary run its tests)? (via https://github.com/cljs-oss/canary/tree/master#how-to-participate)

Since Canary currently only supports Travis, I had added this https://github.com/chkup/reagent/commit/82a676c931afc4d569590847705db4181cff5e7d

Oops, meant https://github.com/chkup/re-frame/commit/d6e44cf488cf17da6ea98c0a9dec334667759ef8

Yeah I guess so, there's no reason for you to have to sync up with master

Yeah, if you'd like to do that, just let me know and I'll "shut down" that re-frame clone I made.

Why does it need Phantom? https://github.com/chkup/re-frame/commit/d6e44cf488cf17da6ea98c0a9dec334667759ef8#diff-a2a3b7b0c9c3b4b93b4aebf4e3ec3cfbL7

No real need... that was just the first thing I found that works. Feel free to try getting it working in its original mode.

Chrome in fact might work. I learned about this after the fact for Reagent: https://github.com/chkup/reagent/commit/26893bba797459dd300bc9b0c7b47cd83c95c409#diff-354f30a63fb0907d4ad57269548329e3R7

Great, also, does this run on every build or just the ones that are triggered by canary?

@danielcompton If you set re-frame up to run in Travis, it would run in Travis for every re-frame commit, and for every "externally-triggered" Canary test run. Here, for example is the mixture you'd get, using Planck as an exammple: https://travis-ci.org/planck-repl/planck/builds

Cool, that's what I expected

Canary would use the Travis token you set up, so it would perhaps run as Daniel Compton, or perhaps some re-frame specific GitHub account if there is such a thing.

nah we don't have anything like that

will talk with Mike Thompson to see about merging it in

As a side note, it would be nice if the canary stuff could live separately from the actual projects, it's a little bit invasive at the moment

Cool. I'll add you to cljs-oss so you can commit stuff for re-frame. Yeah, it is a little invasive, I agree. I have no good answer for that.