@dnolen what whitespace changes are you referring to in CLJS-2317?

oh I see it now

indentation

@dnolen also reworked the bootstrap script not to be dependent on that http://dl.google.com link in the patch that upgrades Closure Compiler: https://dev.clojure.org/jira/browse/CLJS-2316

now we can download it from Maven just like the other deps

Before I report this upstream, just want to make sure this looks like a new bug to you all who are more familiar with the compiler. closure-compiler master is failing on the following JS with --process_common_js_modules set:

var foo = function foo() {
  return 1;
};

module.exports = {
  foo: foo,
};

java.lang.RuntimeException: INTERNAL COMPILER ERROR.
Please report this problem.

EXPR_RESULT 1 [length: 3] [source_file: fails.js]
  Node(NAME foo): fails.js:1:4
var foo = function foo() {
  Parent(VAR): fails.js:1:0
var foo = function foo() {

	at com.google.common.base.Preconditions.checkState(Preconditions.java:444)
	at com.google.javascript.rhino.IR.assign(IR.java:424)
	at com.google.javascript.jscomp.ProcessCommonJSModules$RewriteModule.updateNameReference(ProcessCommonJSModules.java:1100)
	at com.google.javascript.jscomp.ProcessCommonJSModules$RewriteModule.maybeUpdateName(ProcessCommonJSModules.java:982)
	at com.google.javascript.jscomp.ProcessCommonJSModules$RewriteModule.visit(ProcessCommonJSModules.java:727)
...
	

cc @juhoteperi

@anmonteiro it appears CLJS-2316 needs a rebase?

is this still relevant? https://dev.clojure.org/jira/browse/CLJS-2288

@dnolen CLJS-2291 included the same fixes to index-node-modules-dir as my patch, so I'm quite sure it is not relevant

This one is still open: https://dev.clojure.org/jira/browse/CLJS-2294 (just noticed the description is missing some text, but I think the last comment explains the problems at least)

@dnolen rebasing CLJS-2316, will ping when done

CLJS-2288 can be closed

@dnolen replaced CLJS-2316's patch with an updated one

you’ll need to apply it with --keep-cr -p1

are you thinking about cutting a release today?

@anmonteiro yeah I forgot about --keep-cr what does -p1 do?

dunno was in my bash history

@anmonteiro I would like to but I’m not sure I need to fix these :modules issues

maybe only --keep-cr is needed

it applied with --keep-cr

awesome

I’ll still start trying out current master

I don’t have a project with :modules I can try anyway

yeah unlikely to get to a release today - the :modules foreign-lib thing is a bit trickier than expected

well, not so much tricky than the seemingly obvious thing wasn’t going to work and it took a while to figure that out

no rush

was just curious